rinf_cli: init at 8.7.2 #413223
rinf_cli: init at 8.7.2 #413223
Conversation
github-actions
bot
added
8.has: maintainer-list (update)
NixOSInfra
added
the
12.first-time contribution
There was a problem hiding this comment.
Welcome to nixpkgs and thank you for your contribution!
Thank you for asking upstream about providing a lockfile.
Let's continue with fetching the crate for now and see what they respond.
I do not see any problems with this derivation and started a nixpkgs-review run on this PR.
|
JuliusFreudenberger
added
the
12.approvals: 1
|
It's useful to install this with Nix as part of devshells. I don't have Flutter installed on my system. Instead, I use devshells to install dependencies on a per-project basis. |
|
@Noah765 hi, is it possible to add older versions too? for example Flutter 3.24 supports only [email protected] and etc. Maybe rinf_cli-7 would be good version to support. Thanks in advance! |
We are not blocking someone's first PR to Nixpkgs with a request for them to maintain multiple versions of the same package. Please overlay this package with an older version if you need compatibility with older versions of Flutter. |
| meta = { | ||
| mainProgram = "rinf"; | ||
| description = "Rust for native business logic, Flutter for flexible and beautiful GUI"; | ||
| homepage = "https://rinf.cunarist.com"; |
There was a problem hiding this comment.
| homepage = "https://rinf.cunarist.com"; | |
| homepage = "https://rinf.cunarist.com"; | |
| changelog = "https://github.com/cunarist/rinf/releases/tag/v${version}"; |
From @aljazerzen's PR.
| pname = "rinf_cli"; | ||
| version = "8.7.2"; | ||
|
|
||
| src = fetchCrate { |
There was a problem hiding this comment.
It might be worth asking upstream to commit Cargo.Lock per the instructions of the Cargo Book and fetching from GitHub instead, but if they're unresponsive, this isn't blocking.
There was a problem hiding this comment.
Nevermind, missed cunarist/rinf#640. Let's wait a bit for a reply.
pkgs/by-name/ri/rinf_cli/package.nix
Outdated
|
|
||
| meta = { | ||
| mainProgram = "rinf"; | ||
| description = "Rust for native business logic, Flutter for flexible and beautiful GUI"; |
There was a problem hiding this comment.
| description = "Rust for native business logic, Flutter for flexible and beautiful GUI"; | |
| description = "Framework for creating cross-platform Rust apps leveraging Flutter"; |
Per the documentation, the meta.description attribute should avoid subjective/editorialised language and be objective.
I don't think that it is worth maintaining multiple versions of CLI tools like this one just for compatibility, as that would overcrowd nixpkgs with endless amounts of legacy package versions. |
Noah765
force-pushed
the
init-rinf_cli
branch
from
0c62b2d to
449e36d
Compare
5 participants
Rinf is a framework for creating cross-platform Rust apps by using Flutter as the UI layer. The project consists of a Dart package, a Rust crate, and a CLI tool that generates Dart code from Rust structs.
Closes #342071
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.