Skip to content

mcpm: init at 1.13.1 - #413778

Open
luochen1990 wants to merge 1 commit into
NixOS:masterfrom
luochen1990:wip-mcpm
Open

mcpm: init at 1.13.1#413778
luochen1990 wants to merge 1 commit into
NixOS:masterfrom
luochen1990:wip-mcpm

Conversation

@luochen1990

@luochen1990 luochen1990 commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 4, 2025

@JuliusFreudenberger JuliusFreudenberger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments that make the derivation easier. Some of them are minor.

Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
@luochen1990
luochen1990 force-pushed the wip-mcpm branch 2 times, most recently from 0ed5a3f to acafd3a Compare June 4, 2025 10:52
@JuliusFreudenberger

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 413778

Logs: https://github.com/JuliusFreudenberger/nixpkgs-review-gha/actions/runs/15445065739


x86_64-linux (sandbox = true)

✅ 2 packages built:
  • mcpm
  • mcpm.dist

aarch64-linux (sandbox = true)

✅ 2 packages built:
  • mcpm
  • mcpm.dist

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • mcpm
  • mcpm.dist

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • mcpm
  • mcpm.dist

@JuliusFreudenberger JuliusFreudenberger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 9, 2025
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
Comment thread pkgs/by-name/mc/mcpm/package.nix Outdated
@luochen1990

Copy link
Copy Markdown
Contributor Author

Trying to update to v2.10.0, but blocked by: pathintegral-institute/mcpm.sh#274

Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
@nixpkgs-ci nixpkgs-ci Bot added the 8.has: package (new) This PR adds a new package label Jan 26, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants