Skip to content

python3Packages.rlcard: fix build #417828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

python3Packages.rlcard: fix build #417828

merged 1 commit into from
Jun 19, 2025

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jun 18, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 18, 2025
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 417828
Commit: 64d05dde63b91f3006c8a48057afe9d9e7953065

x86_64-linux

✅ 10 packages built:
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.rlcard
  • python312Packages.rlcard.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.tianshou
  • python312Packages.tianshou.dist
  • python313Packages.rlcard
  • python313Packages.rlcard.dist

aarch64-linux

✅ 10 packages built:
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.rlcard
  • python312Packages.rlcard.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.tianshou
  • python312Packages.tianshou.dist
  • python313Packages.rlcard
  • python313Packages.rlcard.dist

x86_64-darwin

✅ 12 packages built:
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.rlcard
  • python312Packages.rlcard.dist
  • python312Packages.tianshou
  • python312Packages.tianshou.dist
  • python313Packages.pettingzoo
  • python313Packages.pettingzoo.dist
  • python313Packages.rlcard
  • python313Packages.rlcard.dist
  • python313Packages.tianshou
  • python313Packages.tianshou.dist

aarch64-darwin

✅ 12 packages built:
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.rlcard
  • python312Packages.rlcard.dist
  • python312Packages.tianshou
  • python312Packages.tianshou.dist
  • python313Packages.pettingzoo
  • python313Packages.pettingzoo.dist
  • python313Packages.rlcard
  • python313Packages.rlcard.dist
  • python313Packages.tianshou
  • python313Packages.tianshou.dist

kirillrdy
kirillrdy reviewed Jun 18, 2025
View reviewed changes
@GaetanLepage GaetanLepage requested a review from kirillrdy June 19, 2025 07:01
@github-actions github-actions bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 19, 2025
@GaetanLepage GaetanLepage merged commit a269ce3 into NixOS:master Jun 19, 2025
23 of 26 checks passed
@GaetanLepage GaetanLepage deleted the rlcard branch June 19, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirillrdy kirillrdy kirillrdy approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaetanLepage @kirillrdy