Skip to content

icestudio: Fix passthru.updateScript#423425

Merged
OPNA2608 merged 1 commit into
NixOS:masterfrom
OPNA2608:fix/icestudio-updateScript
Jul 8, 2025
Merged

icestudio: Fix passthru.updateScript#423425
OPNA2608 merged 1 commit into
NixOS:masterfrom
OPNA2608:fix/icestudio-updateScript

Conversation

@OPNA2608

@OPNA2608 OPNA2608 commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

Was blocking my run of nix-shell maintainers/scripts/update.nix --argstr maintainer OPNA2608:

+ [[ ! v0.12 =~ ^[[:digit:]] ]]
+ echo 'Last tag '\''v0.12'\'' does not start with a digit'
Last tag 'v0.12' does not start with a digit

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 8, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 8, 2025
@OPNA2608 OPNA2608 requested a review from eljamm July 8, 2025 09:35

@eljamm eljamm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eljamm eljamm added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 8, 2025
@OPNA2608 OPNA2608 merged commit 76a8561 into NixOS:master Jul 8, 2025
30 of 34 checks passed
@phanirithvij phanirithvij added the 6.topic: NLNet / NGI The project is part of the NGI funding grant. https://nlnet.nl/NGI/ label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: NLNet / NGI The project is part of the NGI funding grant. https://nlnet.nl/NGI/ 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants