-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
vlagent: init at 1.25.0 #424934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vlagent: init at 1.25.0 #424934
Conversation
|
@sinavir fyi as you have requested vlagent in #423260 (comment) |
7e30d9c to
457afa4
Compare
7ff9f87 to
8472249
Compare
|
I'm not sure if an extra test is worth it for the remote write, I don't have a strong opinion but it could be moved into the other test with subtests so that it tests both scenarios, otherwise looks good to me |
|
yeah i can combine the two scenarios and write one from server machine and keep the remote one, ill take a look. I was first thinking about that, but dropped initially that idea as it might then be hard to tell wether vlagent, journald upload or victorialogs is broken. edit: ah okay i remember again another reason i have choosen 2 tests. |
|
Drafting, seems to have broken something on the latest changes, have to analyse it. |
73562ea to
ef1ec23
Compare
|
So i fixed it again. I hopefully found an acceptable inbetween solution. I am now using |
sinavir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice to me, I think maybe one could add maxDiskUsagePerUrl options because it is useful in my opinion but since we have extraArgs, it is just a suggestion
a8e8f32 to
c105a76
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5704 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5731 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5770 |
Adds vlagent to nixpkgs which is an agent to collect logs from compatible sources and forward them to a victorialogs instance.
With vlagent one can protect a victorialogs instance with basic auth and insert logs via non accessible endpoints from localhost to vlagent without any authentication.
That results in having a quite easy setup without tinkering with mTLS.
The pattern to build vlagent is similar to what is done for vmagent.
Requires #423260 to be merged before and i am planning to rebase this branch after merge.I am already creating it as draft to gather some early feedback on the PR.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.