Skip to content

python313Packages.ledgerblue: fix by dropping unused future dep#438702

Open
SandaruKasa wants to merge 1 commit intoNixOS:masterfrom
SandaruKasa:ledgerblue
Open

python313Packages.ledgerblue: fix by dropping unused future dep#438702
SandaruKasa wants to merge 1 commit intoNixOS:masterfrom
SandaruKasa:ledgerblue

Conversation

@SandaruKasa
Copy link
Contributor

@SandaruKasa SandaruKasa commented Aug 30, 2025

Fixes #438625 by applying LedgerHQ/blue-loader-python#153

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 30, 2025
@SandaruKasa

This comment was marked as outdated.

Sign in to view
@nix-owners nix-owners bot requested a review from np August 30, 2025 19:10
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 30, 2025
@SandaruKasa
Copy link
Contributor Author

SandaruKasa commented Aug 31, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 438702
Commit: dc06a0111f776a15c951439321ab1e25670f7e9a

x86_64-linux

✅ 8 packages built:
  • ledger-agent (python313Packages.ledger-agent)
  • ledger-agent.dist (python313Packages.ledger-agent.dist)
  • python312Packages.ledger-agent
  • python312Packages.ledger-agent.dist
  • python312Packages.ledgerblue
  • python312Packages.ledgerblue.dist
  • python313Packages.ledgerblue
  • python313Packages.ledgerblue.dist

@qweered qweered closed this Jan 21, 2026
@qweered qweered reopened this Jan 21, 2026
@qweered
Copy link
Contributor

qweered commented Jan 21, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 438702
Commit: dc06a0111f776a15c951439321ab1e25670f7e9a (subsequent changes)
Merge: db72eda675bd26503147b56d1f830a67f73c4a5d

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/21192102785

x86_64-linux

⏩ 6 packages marked as broken and skipped:
  • ledger-agent
  • ledger-agent.dist
  • python313Packages.ledger-agent
  • python313Packages.ledger-agent.dist
  • python314Packages.ledger-agent
  • python314Packages.ledger-agent.dist
✅ 4 packages built:
  • python313Packages.ledgerblue
  • python313Packages.ledgerblue.dist
  • python314Packages.ledgerblue
  • python314Packages.ledgerblue.dist

aarch64-linux

⏩ 6 packages marked as broken and skipped:
  • ledger-agent
  • ledger-agent.dist
  • python313Packages.ledger-agent
  • python313Packages.ledger-agent.dist
  • python314Packages.ledger-agent
  • python314Packages.ledger-agent.dist
✅ 4 packages built:
  • python313Packages.ledgerblue
  • python313Packages.ledgerblue.dist
  • python314Packages.ledgerblue
  • python314Packages.ledgerblue.dist

x86_64-darwin (sandbox = relaxed)

❌ 4 packages failed to build:
  • python313Packages.ledgerblue
  • python313Packages.ledgerblue.dist
  • python314Packages.ledgerblue
  • python314Packages.ledgerblue.dist
Error logs: `x86_64-darwin`
python313Packages.ledgerblue 
adding 'ledgerblue/verifyEndorsement2.py'
adding 'ledgerblue/vss.py'
adding 'ledgerblue-0.1.55.dist-info/licenses/LICENSE'
adding 'ledgerblue-0.1.55.dist-info/METADATA'
adding 'ledgerblue-0.1.55.dist-info/WHEEL'
adding 'ledgerblue-0.1.55.dist-info/top_level.txt'
adding 'ledgerblue-0.1.55.dist-info/RECORD'
removing build/bdist.macosx-14.0-x86_64/wheel
Successfully built ledgerblue-0.1.55-py3-none-any.whl
Finished creating a wheel...
/nix/build/nix-4057-3222704690/ledgerblue-0.1.55/dist /nix/build/nix-4057-3222704690/ledgerblue-0.1.55
Unpacking to: unpacked/ledgerblue-0.1.55...OK
Repacking wheel as ./ledgerblue-0.1.55-py3-none-any.whl...OK
/nix/build/nix-4057-3222704690/ledgerblue-0.1.55
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for ledgerblue-0.1.55-py3-none-any.whl
  - bleak not installed
python314Packages.ledgerblue 
adding 'ledgerblue/verifyEndorsement2.py'
adding 'ledgerblue/vss.py'
adding 'ledgerblue-0.1.55.dist-info/licenses/LICENSE'
adding 'ledgerblue-0.1.55.dist-info/METADATA'
adding 'ledgerblue-0.1.55.dist-info/WHEEL'
adding 'ledgerblue-0.1.55.dist-info/top_level.txt'
adding 'ledgerblue-0.1.55.dist-info/RECORD'
removing build/bdist.macosx-14.0-x86_64/wheel
Successfully built ledgerblue-0.1.55-py3-none-any.whl
Finished creating a wheel...
/nix/build/nix-4057-3222704691/ledgerblue-0.1.55/dist /nix/build/nix-4057-3222704691/ledgerblue-0.1.55
Unpacking to: unpacked/ledgerblue-0.1.55...OK
Repacking wheel as ./ledgerblue-0.1.55-py3-none-any.whl...OK
/nix/build/nix-4057-3222704691/ledgerblue-0.1.55
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for ledgerblue-0.1.55-py3-none-any.whl
  - bleak not installed

aarch64-darwin (sandbox = relaxed)

❌ 4 packages failed to build:
  • python313Packages.ledgerblue
  • python313Packages.ledgerblue.dist
  • python314Packages.ledgerblue
  • python314Packages.ledgerblue.dist
Error logs: `aarch64-darwin`
python313Packages.ledgerblue 
adding 'ledgerblue/verifyEndorsement2.py'
adding 'ledgerblue/vss.py'
adding 'ledgerblue-0.1.55.dist-info/licenses/LICENSE'
adding 'ledgerblue-0.1.55.dist-info/METADATA'
adding 'ledgerblue-0.1.55.dist-info/WHEEL'
adding 'ledgerblue-0.1.55.dist-info/top_level.txt'
adding 'ledgerblue-0.1.55.dist-info/RECORD'
removing build/bdist.macosx-14.0-arm64/wheel
Successfully built ledgerblue-0.1.55-py3-none-any.whl
Finished creating a wheel...
/nix/build/nix-5092-1238484257/ledgerblue-0.1.55/dist /nix/build/nix-5092-1238484257/ledgerblue-0.1.55
Unpacking to: unpacked/ledgerblue-0.1.55...OK
Repacking wheel as ./ledgerblue-0.1.55-py3-none-any.whl...OK
/nix/build/nix-5092-1238484257/ledgerblue-0.1.55
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for ledgerblue-0.1.55-py3-none-any.whl
  - bleak not installed

@happysalada
Copy link
Contributor

happysalada commented Jan 21, 2026

@np as the maintainer of ledger blue, what do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@np np Awaiting requested review from np

@kirillrdy kirillrdy Awaiting requested review from kirillrdy

@happysalada happysalada Awaiting requested review from happysalada

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: python313Packages.ledgerblue

3 participants

@SandaruKasa @qweered @happysalada