Skip to content

Conversation

@ttytm
Copy link

@ttytm ttytm commented Sep 16, 2025

This PR intends to update the version of onlyoffice-desktopeditors.
One of the important changes in the updated version is a fix for running the application when the --system-title-bar flag is passed (or the equivalent titlebar=system option in DesktopEditors.conf is set), which was broken in 9.0.0 and caused the application to crash on startup.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Sep 16, 2025
@nix-owners nix-owners bot requested review from GTrunSec and nh2 September 16, 2025 13:34
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 443429
Commit: 02d7e2ef973e77f1fd020e499ca71eb6cd70faae


x86_64-linux

✅ 1 package built:
  • onlyoffice-desktopeditors

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 16, 2025
iedame

This comment was marked as outdated.

@iedame

This comment was marked as outdated.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 18, 2025
@iedame
Copy link
Contributor

iedame commented Oct 28, 2025

Version bump to 9.1.0, please? https://github.com/ONLYOFFICE/DesktopEditors/releases/tag/v9.1.0

@ttytm
Copy link
Author

ttytm commented Oct 29, 2025

Version bump to 9.1.0, please? https://github.com/ONLYOFFICE/DesktopEditors/releases/tag/v9.1.0

Would bump it in the PR today

@ttytm ttytm requested review from ddogfoodd and iedame October 30, 2025 12:43
@iedame
Copy link
Contributor

iedame commented Oct 30, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 443429
Commit: ff10a3b1bd3971a1ba34d7f8506d7f5fe172aba5 (subsequent changes)
Merge: 6d77a51144093bc33c090208ec54431771883f56

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18942557217


x86_64-linux

✅ 1 package built:
  • onlyoffice-desktopeditors

aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@ttytm ttytm changed the title onlyoffice-desktopeditors: 9.0.0 -> 9.0.4 onlyoffice-desktopeditors: 9.0.0 -> 9.1.0 Oct 30, 2025
@avivbintangaringga
Copy link

Waiting for this one to be merged 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants