Skip to content

python313Packages.readabilipy: fix build#446889

Merged
fabaff merged 1 commit intoNixOS:masterfrom
natsukium:readabilipy/fix
Sep 28, 2025
Merged

python313Packages.readabilipy: fix build#446889
fabaff merged 1 commit intoNixOS:masterfrom
natsukium:readabilipy/fix

Conversation

@natsukium
Copy link
Copy Markdown
Member

@natsukium natsukium commented Sep 28, 2025

see alan-turing-institute/ReadabiliPy#116

https://hydra.nixos.org/build/306992153

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@natsukium natsukium added the 0.kind: build failure A package fails to build label Sep 28, 2025
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Sep 28, 2025
@natsukium natsukium mentioned this pull request Sep 28, 2025
Closed
@nix-owners nix-owners Bot requested a review from fabaff September 28, 2025 11:28
@nixpkgs-ci nixpkgs-ci Bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 28, 2025
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Sep 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 446889
Commit: 5e97d27d362fedbf94314cbc06b01b4e3982746d

x86_64-linux

✅ 8 packages built:
  • iocsearcher (python313Packages.iocsearcher)
  • iocsearcher.dist (python313Packages.iocsearcher.dist)
  • python312Packages.iocsearcher
  • python312Packages.iocsearcher.dist
  • python312Packages.readabilipy
  • python312Packages.readabilipy.dist
  • python313Packages.readabilipy
  • python313Packages.readabilipy.dist

fabaff
fabaff approved these changes Sep 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff added this pull request to the merge queue Sep 28, 2025
Merged via the queue into NixOS:master with commit 8536e64 Sep 28, 2025
34 of 36 checks passed
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 28, 2025
@natsukium natsukium deleted the readabilipy/fix branch September 29, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

No one assigned

Labels

0.kind: build failure A package fails to build 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@natsukium @fabaff