hercules-ci-agent: Fix build on aarch64-darwin - #463879
Merged
Merged
Conversation
nixpkgs-ci
Bot
requested review from
cdepillabout,
guibou,
maralorn,
sternenseemann and
wolfgangwalther
November 21, 2025 23:49
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
roberth
force-pushed
the
fix-hci
branch
2 times, most recently
from
November 21, 2025 23:53
d8a57d8 to
544c4e8
Compare
Member
Author
|
Is there anything else to be done? |
Contributor
|
It's quite unsatisfactory to have such a targeted and unprincipled hack without any path forward to remove it anytime soon. If older compilers are not affected by this, can't we just build |
Member
Author
|
I agree that the solution isn't pretty necessarily, but loading a Haskell program + RTS + nix libraries into a single process global symbol namespace works fine, as demonstrated by
This would require hydra to build a significant portion of this package set, whereas currently it only has to build ghc itself at this version. |
Contributor
9.8.4 is also affected. I believe 9.8.2 is the latest in the 9.8 series without the linker changes that cause the build failure. |
Member
|
Why was this working fine with 9.8.4 then? |
Contributor
@sternenseemann it actually worked fine with both 9.8.4 and 9.10.3. |
Contributor
cc @NixOS/darwin-core, maybe you have some input to this as well. |
Contributor
|
The only thing we build from dyld are a couple of tools ( |
Contributor
|
I'm not convinced, yet, that this the right thing to do. Imho, this should be fully bisected. I started that, but didn't finish. I have it down to: git bisect view --oneline |
nixpkgs-ci
Bot
added
10.rebuild-darwin: 1-10
Member
Author
|
Thank you @wolfgangwalther. I haven't quite figured that one out either. The bad commit produced a different problem, and some more recent commits actually built successfully somehow. The good news is I've found a new workaround that doesn't require any changes to GHC or anything like that. |
Contributor
|
nixpkgs-ci
Bot
added
the
12.approvals: 1
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hercules-ci-agentstill needs the fix by @sandydoo in order to build.I've made it conditional to nullify the possible impact elsewhere.
Long term I'd like to get rid of the TemplateHaskell that's triggering this problem, but that's blocked on a number of issues.
So a workaround is needed.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.