Skip to content

python314Packages.kantoku: disable broken tests for python >= 3.14 #478255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabaff merged 2 commits into from
Jan 9, 2026
Merged

python314Packages.kantoku: disable broken tests for python >= 3.14 #478255

fabaff merged 2 commits into from
Jan 9, 2026

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented Jan 9, 2026 •
edited
Loading

  1. The command line output has changed from python3 to python3.14, breaking three tests. Disabled.
  2. Added finalAttrs fix.

Tracking: #475732

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@sarahec
Copy link
Contributor Author

sarahec commented Jan 9, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478255
Commit: d5006e634c7dbdccd6abeee6f5988410a0fe3251

aarch64-darwin

✅ 2 packages built:
  • python314Packages.kantoku
  • python314Packages.kantoku.dist

@nixpkgs-ci nixpkgs-ci bot requested a review from fabaff January 9, 2026 01:41
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 9, 2026
@sarahec
Copy link
Contributor Author

sarahec commented Jan 9, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478255
Commit: ecf33ce9666d99f546b8694d68de8035c900f0f9

x86_64-linux

✅ 2 packages built:
  • python314Packages.kantoku
  • python314Packages.kantoku.dist

fabaff
fabaff approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff added this pull request to the merge queue Jan 9, 2026
Merged via the queue into NixOS:master with commit 946b40d Jan 9, 2026
29 of 33 checks passed
@sarahec sarahec deleted the py314-kantoku branch January 9, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarahec @fabaff