Skip to content

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Jan 9, 2026

gdalMinimal is used for vtk's IO module
this pr reduce clousure size of vtk (no loonger depend on openjdk). also helps building vtk on loongarch64

first commit should triger zero rebuild, just make sure python3Packages.vtk/gdal use the same python3Packages.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 9, 2026
Copy link
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @qbisi

adios2 = self.callPackage adios2.override { };
cgns = self.callPackage cgns.override { };
viskores = self.callPackage viskores.override { };
gdal = self.callPackage gdal.override { useMinimalFeatures = true; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

Suggested change
gdal = self.callPackage gdal.override { useMinimalFeatures = true; };
gdal = self.callPackage gdalMinimal { }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personly, i will use gdalMinimal as input driectly only if i don't need to override it. I should admit the commit message "vtk: use gdalMinimal" might be confusing as i have not use gdalMinimal as the input. Maybe "vtk: use gdal with minimalFeatures" matches better.

@imincik
Copy link
Contributor

imincik commented Jan 9, 2026

I am running nixpkgs-review now ...

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 9, 2026
@qbisi
Copy link
Contributor Author

qbisi commented Jan 9, 2026

I am running nixpkgs-review now ...

Thanks, my poor machine cannot afford this.

@imincik
Copy link
Contributor

imincik commented Jan 9, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478275
Commit: 66c0becebcc5fe29f59eca1aacb082b7b2160fc6


x86_64-linux

❌ 21 packages failed to build:
  • ezminc
  • itk_5_2
  • otb
  • python313Packages.pyotb
  • python313Packages.pyotb.dist
  • python314Packages.dicom2nifti
  • python314Packages.dicom2nifti.dist
  • python314Packages.fast-simplification
  • python314Packages.fast-simplification.dist
  • python314Packages.gstools
  • python314Packages.gstools.dist
  • python314Packages.pykrige
  • python314Packages.pykrige.dist
  • python314Packages.pymedio
  • python314Packages.pymedio.dist
  • python314Packages.pyotb
  • python314Packages.pyotb.dist
  • python314Packages.pyvista
  • python314Packages.pyvista.dist
  • python314Packages.torchio
  • python314Packages.torchio.dist
✅ 92 packages built:
  • ants
  • appcsxcad
  • c3d
  • cloudcompare
  • csxcad
  • elastix
  • elmerfem
  • exhibit
  • f3d
  • f3d.man
  • freecad
  • gdcm
  • itk (itk_5)
  • mirtk
  • mrtrix
  • octavePackages.dicom
  • openems
  • paraview
  • parmmg
  • parmmg.dev
  • pcl
  • python313Packages.dicom2nifti
  • python313Packages.dicom2nifti.dist
  • python313Packages.f3d
  • python313Packages.f3d.man
  • python313Packages.fast-simplification
  • python313Packages.fast-simplification.dist
  • python313Packages.firedrake
  • python313Packages.firedrake.dist
  • python313Packages.gdcm
  • python313Packages.gstools
  • python313Packages.gstools.dist
  • python313Packages.itk
  • python313Packages.mayavi
  • python313Packages.mayavi.dist
  • python313Packages.medpy
  • python313Packages.medpy.dist
  • python313Packages.medvol
  • python313Packages.medvol.dist
  • python313Packages.napari-nifti
  • python313Packages.napari-nifti.dist
  • python313Packages.opencv4Full
  • python313Packages.opencv4Full.cxxdev
  • python313Packages.opencv4Full.package_tests
  • python313Packages.pykrige
  • python313Packages.pykrige.dist
  • python313Packages.pymedio
  • python313Packages.pymedio.dist
  • python313Packages.pyradiomics
  • python313Packages.pyradiomics.dist
  • python313Packages.python-csxcad
  • python313Packages.python-csxcad.dist
  • python313Packages.pyvista
  • python313Packages.pyvista.dist
  • python313Packages.simpleitk
  • python313Packages.simpleitk.dist
  • python313Packages.torchio
  • python313Packages.torchio.dist
  • python313Packages.vtk
  • python314Packages.f3d
  • python314Packages.f3d.man
  • python314Packages.firedrake
  • python314Packages.firedrake.dist
  • python314Packages.gdcm
  • python314Packages.itk
  • python314Packages.mayavi
  • python314Packages.mayavi.dist
  • python314Packages.medpy
  • python314Packages.medpy.dist
  • python314Packages.medvol
  • python314Packages.medvol.dist
  • python314Packages.napari-nifti
  • python314Packages.napari-nifti.dist
  • python314Packages.opencv4Full
  • python314Packages.opencv4Full.cxxdev
  • python314Packages.opencv4Full.package_tests
  • python314Packages.pyradiomics
  • python314Packages.pyradiomics.dist
  • python314Packages.python-csxcad
  • python314Packages.python-csxcad.dist
  • python314Packages.simpleitk
  • python314Packages.simpleitk.dist
  • python314Packages.vtk
  • qcsxcad
  • qcsxcad.dev
  • rtabmap
  • simpleitk
  • therion
  • vtk (vtk_9_5)
  • vtk-dicom
  • vtk-full
  • vtkWithQt6

Error logs: `x86_64-linux`
itk_5_2
[ 54%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/opt/lbfgsb.c.o
[ 54%] Building CXX object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/linalg/lsqrBase.cxx.o
[ 54%] Building CXX object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/linalg/lsqrDense.cxx.o
[ 55%] Building CXX object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/linalg/lsmrBase.cxx.o
[ 55%] Building CXX object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/linalg/lsmrDense.cxx.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/toms/rpoly.c.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/datapac/camsun.c.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/mathews/simpson.c.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/mathews/trapezod.c.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/sparse/spAllocate.c.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/sparse/spBuild.c.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/sparse/spFactor.c.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/sparse/spSolve.c.o
[ 55%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/sparse/spUtils.c.o
[ 56%] Building C object Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeFiles/itkv3p_netlib.dir/sparse/spOutput.c.o
[ 56%] Linking CXX shared library ../../../../../../../lib/libitkv3p_netlib-5.2.so
[ 56%] Built target itkv3p_netlib
[ 56%] Linking CXX shared library ../../../../../../../lib/libitkvnl-5.2.so
[ 56%] Built target itkvnl
make: *** [Makefile:156: all] Error 2
python314Packages.pyvista
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/pmb8clh66mryha2ijzz3dg969drrkgj7-python3-3.14.2/lib/python3.14/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1398, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1371, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1342, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 938, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 759, in exec_module
  File "<frozen importlib._bootstrap>", line 491, in _call_with_frames_removed
  File "/nix/store/1mwp8ni7sf5153bdpxzhj9g7q0znjigs-python3.14-pyvista-0.46.4/lib/python3.14/site-packages/pyvista/__init__.py", line 14, in <module>
    from pyvista.core import *
  File "/nix/store/1mwp8ni7sf5153bdpxzhj9g7q0znjigs-python3.14-pyvista-0.46.4/lib/python3.14/site-packages/pyvista/core/__init__.py", line 6, in <module>
    from ._typing_core import *
  File "/nix/store/1mwp8ni7sf5153bdpxzhj9g7q0znjigs-python3.14-pyvista-0.46.4/lib/python3.14/site-packages/pyvista/core/_typing_core/__init__.py", line 5, in <module>
    from ._aliases import ArrayLike as ArrayLike
  File "/nix/store/1mwp8ni7sf5153bdpxzhj9g7q0znjigs-python3.14-pyvista-0.46.4/lib/python3.14/site-packages/pyvista/core/_typing_core/_aliases.py", line 40, in <module>
    VectorLike.__doc__ = """One-dimensional array-like object with numerical values.
    ^^^^^^^^^^^^^^^^^^
AttributeError: 'typing.Union' object attribute '__doc__' is read-only

@qbisi
Copy link
Contributor Author

qbisi commented Jan 9, 2026

itk-5.2/itk-5.3/python314Packages.pyvista are known failure on hydra after recent staging-next cycle merged into master with gcc upgrading to gcc15.

python314Packages.pyvista will be built when new pyvista 0.47.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants