-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
vtk: use gdalMinimal instead of gdal #478275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
imincik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @qbisi
| adios2 = self.callPackage adios2.override { }; | ||
| cgns = self.callPackage cgns.override { }; | ||
| viskores = self.callPackage viskores.override { }; | ||
| gdal = self.callPackage gdal.override { useMinimalFeatures = true; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
| gdal = self.callPackage gdal.override { useMinimalFeatures = true; }; | |
| gdal = self.callPackage gdalMinimal { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personly, i will use gdalMinimal as input driectly only if i don't need to override it. I should admit the commit message "vtk: use gdalMinimal" might be confusing as i have not use gdalMinimal as the input. Maybe "vtk: use gdal with minimalFeatures" matches better.
|
I am running nixpkgs-review now ... |
Thanks, my poor machine cannot afford this. |
|
|
itk-5.2/itk-5.3/python314Packages.pyvista are known failure on hydra after recent staging-next cycle merged into master with gcc upgrading to gcc15. python314Packages.pyvista will be built when new pyvista 0.47.0 released. |
gdalMinimal is used for vtk's IO module
this pr reduce clousure size of vtk (no loonger depend on openjdk). also helps building vtk on loongarch64
first commit should triger zero rebuild, just make sure python3Packages.vtk/gdal use the same python3Packages.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.