Skip to content

Add Benzene to maintainer list#501196

Open
Benzenec6h6 wants to merge 1 commit intoNixOS:masterfrom
Benzenec6h6:master
Open

Add Benzene to maintainer list#501196
Benzenec6h6 wants to merge 1 commit intoNixOS:masterfrom
Benzenec6h6:master

Conversation

@Benzenec6h6
Copy link

Add myself as a maintainer in preparation for submitting the moomoo desktop package.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Mar 19, 2026
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, is it preferred to avoid adding yourself in the maintainer list if you are not maintaining anything. Since you want to add a package, you can submit it in the same pr as the one you are declaring yourself within the maintainer list.

For this make sure to split the commits adequately:

  • maintainers: add Benzene
  • moomoo: init at ...

I suggest repurposing this pr to add the package your are planning to submit, this way you only need to add the new commit (and reword the current one)

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants