Open
Conversation
Sigmanificient
requested changes
Mar 19, 2026
Member
There was a problem hiding this comment.
Hi, is it preferred to avoid adding yourself in the maintainer list if you are not maintaining anything. Since you want to add a package, you can submit it in the same pr as the one you are declaring yourself within the maintainer list.
For this make sure to split the commits adequately:
maintainers: add Benzenemoomoo: init at ...
I suggest repurposing this pr to add the package your are planning to submit, this way you only need to add the new commit (and reword the current one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add myself as a maintainer in preparation for submitting the moomoo desktop package.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.