ubootRock5ModelC: init#506030
Open
marijanp wants to merge 1 commit intoNixOS:masterfrom
Open
Conversation
2 tasks
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created an image using disko, and using a nixos-hardware module which will be contributed as soon as this lands, which sets the platformFirmware to this package. The machine boots and seems fully functional.
I never contributed a package like this so I'm unsure what else needs to be verified.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.