ltfs: init at 2.4.8.4-10522 - #509379
Conversation
implr
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nixpkgs-ci
Bot
added
8.has: package (new)
nixpkgs-ci
Bot
added
the
10.rebuild-nixos-tests
![nixpkgs-branch-check[bot]](https://avatars.githubusercontent.com/u/487568?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
implr
changed the title
Review dismissed automatically
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
|
You may wanted to also reword your commit message(+ pr title) too. |
|
Done, plus a version bump - there's been a new release since I started this PR. |
|
MiniHarinn
left a comment
MiniHarinn
left a comment
There was a problem hiding this comment.
sorry for a late review, changes lgtm, thanks!
nixpkgs-ci
Bot
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/3236 |
| ]; | ||
|
|
||
| buildInputs = [ | ||
| fuse |
There was a problem hiding this comment.
There is currently an ongoing effort to deprecate and remove all use of fuse 2: #526161
There is an upstream PR that adds fuse3 support, maybe you could use it as a patch?
| description = "Reference implementation of the open-source tape filesystem standard ltfs"; | ||
| homepage = "https://github.com/LinearTapeFileSystem/ltfs"; | ||
| license = lib.licenses.bsd3; | ||
| platforms = with lib.platforms; linux ++ darwin ++ freebsd ++ netbsd; |
There was a problem hiding this comment.
| platforms = with lib.platforms; linux ++ darwin ++ freebsd ++ netbsd; | |
| platforms = lib.platforms.unix; |
Seems like you have all the major players anyway (not a blocking change, but one you should consider).
There was a problem hiding this comment.
lib.platforms is and has for a long time been in a weird state where catchalls like unix and all include all sorts of platforms you would not expect. lib.platforms.unix implies that you expect the package to work on operating systems like redox where fuse just isn't available. I tend to ignore it when the original PR contains this (fixing the problem would need some sort of giant treewide and herculean effort anyway), but I don't think we should encourage being less precise.
SuperSandro2000
changed the title
| version = "2.4.8.4-10522"; | ||
| pname = "ltfs"; |
There was a problem hiding this comment.
| version = "2.4.8.4-10522"; | |
| pname = "ltfs"; | |
| pname = "ltfs"; | |
| version = "2.4.8.4-10522"; |
| tag = "v${finalAttrs.version}"; | ||
| fetchSubmodules = true; | ||
| owner = "LinearTapeFileSystem"; | ||
| repo = "ltfs"; | ||
| hash = "sha256-E3qMdZL7UF/phUjayxLGBLpDG9rDXzG5cFECY+tlNlM="; |
There was a problem hiding this comment.
| tag = "v${finalAttrs.version}"; | |
| fetchSubmodules = true; | |
| owner = "LinearTapeFileSystem"; | |
| repo = "ltfs"; | |
| hash = "sha256-E3qMdZL7UF/phUjayxLGBLpDG9rDXzG5cFECY+tlNlM="; | |
| owner = "LinearTapeFileSystem"; | |
| repo = "ltfs"; | |
| tag = "v${finalAttrs.version}"; | |
| fetchSubmodules = true; | |
| hash = "sha256-E3qMdZL7UF/phUjayxLGBLpDG9rDXzG5cFECY+tlNlM="; |
| autoconf | ||
| automake |
There was a problem hiding this comment.
| autoconf | |
| automake |
| automake | ||
| autoreconfHook | ||
| icu78 | ||
| libtool |
There was a problem hiding this comment.
| libtool |
Those things are already in autoreconfHook
6 participants
We already have
hpe-ltfs, but it's ancient. Adding the open upstream.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.