minecraftServers: move to by-name

[zimward]

named minecraftServers because the package set is named that

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[phanirithvij]

I think nixpkgs-vet is wrong here. recurseForDerivations works fine with pkgs/by-name.

[zimward]

I think nixpkgs-vet is wrong here. recurseForDerivations works fine with pkgs/by-name.

yeah there is a open issue for that on nixpkgs-vet

[mdaniels5757]

Per pkgs/by-name/README.md, "[t]he return value [of each package.nix] must be a derivation". Even if it "works" (and I haven't tested myself) to have non-derivation return values, it breaks assumptions of nixpkgs-vet and the merge bot to have non-derivation package.nix return values, and doing so is also contrary to the design in NixOS/rfcs#140.

You need NixOS/rfcs#197, I think.

[zimward]

the readme also documents exporting a set of derivations though which is what i do here

[phanirithvij]

@zimward, you have to refactor this to do what the readme is suggesting for multi version packages.

Instead of exposing an atrrset of packages in package.nix, you need to turn that into a single derivation. And in all-packages.nix you have to do the trick mentioned in the section you linked. So recurseForDerivations removed and the full attrset needs to be refactored.

[phanirithvij]

Actually this worked

• moving the package.nix to a versions.nix.
  • no need to remove the lib.recurseIntoAttrs
• moving the pkgs/by-name/minecraftServers to pkgs/by-name/minecraft-server
  • as minecraft-server is an existing package the new strictDeps and __structuredAttrs are not required to be added.
• adding a package.nix with {callPackage}: (callPackage ./versions.nix { }).vanilla
  • remove the minecraft-server = minecraftServers.vanilla; in all-packages
  • set minecraftServers = callPackage ../by-name/mi/minecraft-server/versions.nix { };

[phanirithvij]

@mdaniels5757 please review. It is now passing vet.