antigravity: rename to antigravity-ide#522168
Conversation
0fdbb02 to
858ba6f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
858ba6f to
34cec59
Compare
Zaczero
left a comment
There was a problem hiding this comment.
didnt build/run, reviewed the diff alone
| strictDeps = true; | ||
| __structuredAttrs = true; |
There was a problem hiding this comment.
|
|
Thanks, was just catching up on Google IO announcements and came looking to see if these PRs existed, appreciate it. |
|
I'm not sure about this rename, 2.0.0 removes the "IDE" part from Antigravity, it's basically a chat window now. 😞 EDIT: my bad, google officially renamed it to -ide to distinguish from -cli (replacing gemini-cli) ... it's unfortunate they removed almost all of the ide features out of it to make it into a poor clone of codex. |
|
They also butchered the cli and made it closed source. Not much good in the antigravity world atm |
3ce5c01 to
da23e14
Compare
|
| fhs = fhs { }; | ||
| fhsWithPackages = f: fhs { additionalPkgs = f; }; | ||
| fhs = (fhs { }).overrideAttrs (old: { | ||
| strictDeps = true; |
There was a problem hiding this comment.
Why not just change config in pkgs/applications/editors/vscode
There was a problem hiding this comment.
I'm not sure I get what you mean, isn't this edit in pkgs/applications/editors/vscode?
There was a problem hiding this comment.
Actually is this actually needed? You added stucturedAtrrs and stictdeps above, doesn't fhs intherits it?
There was a problem hiding this comment.
Actually is this actually needed? You added stucturedAtrrs and stictdeps above, doesn't fhs intherits it?
Seems to fail without them:
https://github.com/NixOS/nixpkgs/actions/runs/26289931300/job/77387260084?pr=522168
There was a problem hiding this comment.
The build log says this isn't the right place for this change:
> - Attribute `pkgs.antigravity-ide-fhs` is a new package with `strictDeps` unset or set to `false`.
> Please enable `strictDeps = true;` in pkgs/top-level/all-packages.nix.
> (NPV-164)
> - Attribute `pkgs.antigravity-ide-fhs` is a new package with `__structuredAttrs` unset or set to `false`.
> Please enable `__structuredAttrs = true;` in pkgs/top-level/all-packages.nix.There was a problem hiding this comment.
The build log says this isn't the right place for this change:
It was like that before this request:
There was a problem hiding this comment.
There should be a better way to inherit them in builder, without overrideAttrs. New instances of overrideAttrs shouldn't be introduced
There was a problem hiding this comment.
There should be a better way to inherit them in builder, without overrideAttrs. New instances of overrideAttrs shouldn't be introduced
The only other way I can think of right now is adding something like this to the build-fhs-env-bubblewrap/default.nix:
// lib.optionalAttrs (args ? strictDeps) {
inherit (args) strictDeps;
}
// lib.optionalAttrs (args ? __structuredAttrs) {
inherit (args) __structuredAttrs;
}I don't know if this is preferred?
c37e95e to
be61cfe
Compare
be61cfe to
f625271
Compare
|
I gave the PR a try and hit a problem with the agent, but I think I've found the fix (using Antigravity itself) — sharing in case it's useful.
and once that's past, the agent's shell-outs fail identically: With the current FHS-based packaging the agent can't run anything; every command tool call comes back as: which is the user-facing face of the Putting .overrideAttrs (oldAttrs: {
preFixup = (oldAttrs.preFixup or "") + ''
gappsWrapperArgs+=( --prefix PATH : "/nix/store" )
'';
})Verified: the agent starts and its terminal runs arbitrary tools (git, jj, nix, …). P.S. FYI the same issue affects antigravity-hub. The fix is also the same - 7b88d0f |
Changelog:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.