Skip to content

antigravity: rename to antigravity-ide#522168

Open
schembriaiden wants to merge 2 commits into
NixOS:masterfrom
schembriaiden:antigravity--rename-to-antigravity-ide
Open

antigravity: rename to antigravity-ide#522168
schembriaiden wants to merge 2 commits into
NixOS:masterfrom
schembriaiden:antigravity--rename-to-antigravity-ide

Conversation

@schembriaiden

@schembriaiden schembriaiden commented May 20, 2026

Copy link
Copy Markdown
Contributor

Changelog:

Things done

@nixpkgs-ci nixpkgs-ci Bot requested review from Zaczero and xiaoxiangmoe May 20, 2026 07:54
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels May 20, 2026
@schembriaiden schembriaiden force-pushed the antigravity--rename-to-antigravity-ide branch 4 times, most recently from 0fdbb02 to 858ba6f Compare May 20, 2026 08:14
@schembriaiden

This comment was marked as outdated.

@schembriaiden schembriaiden force-pushed the antigravity--rename-to-antigravity-ide branch from 858ba6f to 34cec59 Compare May 20, 2026 08:48

@Zaczero Zaczero left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt build/run, reviewed the diff alone

Comment thread pkgs/top-level/all-packages.nix Outdated
Comment on lines +10513 to +10514
strictDeps = true;
__structuredAttrs = true;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is that

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 20, 2026
@khaneliman

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 522168
Commit: 34cec59d112b292306645dca556244a71e24fb05


x86_64-linux

✅ 2 packages built:
  • antigravity-ide
  • antigravity-ide-fhs

aarch64-linux

✅ 2 packages built:
  • antigravity-ide
  • antigravity-ide-fhs

aarch64-darwin

✅ 1 package built:
  • antigravity-ide

@khaneliman

Copy link
Copy Markdown
Contributor

Thanks, was just catching up on Google IO announcements and came looking to see if these PRs existed, appreciate it.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 20, 2026
@deftdawg

deftdawg commented May 21, 2026

Copy link
Copy Markdown
Contributor

I'm not sure about this rename, 2.0.0 removes the "IDE" part from Antigravity, it's basically a chat window now. 😞

EDIT: my bad, google officially renamed it to -ide to distinguish from -cli (replacing gemini-cli) ... it's unfortunate they removed almost all of the ide features out of it to make it into a poor clone of codex.

@schembriaiden

Copy link
Copy Markdown
Contributor Author

I'm not sure about this rename, 2.0.0 removes the "IDE" part from Antigravity, it's basically a chat window now. 😞

https://antigravity.google/product/antigravity-ide

@khaneliman

Copy link
Copy Markdown
Contributor

I'm not sure about this rename, 2.0.0 removes the "IDE" part from Antigravity, it's basically a chat window now. 😞

EDIT: my bad, google officially renamed it to -ide to distinguish from -cli (replacing gemini-cli) ... it's unfortunate they removed almost all of the ide features out of it to make it into a poor clone of codex.

They also butchered the cli and made it closed source. Not much good in the antigravity world atm

Comment thread pkgs/by-name/an/antigravity-ide/package.nix Outdated
@schembriaiden schembriaiden force-pushed the antigravity--rename-to-antigravity-ide branch 2 times, most recently from 3ce5c01 to da23e14 Compare May 22, 2026 08:35
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels May 22, 2026
@schembriaiden

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 522168
Commit: da23e1455420389731fc6b9b757dd3608db9ee25 (subsequent changes)
Merge: 8d4e798bccdc4aadfe20700aedeb41542d180d4f

Logs: https://github.com/schembriaiden/nixpkgs-review-gha/actions/runs/26277506997


x86_64-linux

✅ 12 packages built:
  • antigravity-ide
  • antigravity-ide-fhs
  • code-cursor
  • code-cursor-fhs
  • kiro
  • kiro-fhs
  • vscode
  • vscode-fhs
  • vscode-with-extensions
  • vscodium
  • vscodium-fhs
  • windsurf

aarch64-linux

✅ 9 packages built:
  • antigravity-ide
  • antigravity-ide-fhs
  • code-cursor
  • code-cursor-fhs
  • vscode
  • vscode-fhs
  • vscode-with-extensions
  • vscodium
  • vscodium-fhs

x86_64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • kiro
✅ 6 packages built:
  • antigravity-ide
  • code-cursor
  • vscode
  • vscode-with-extensions
  • vscodium
  • windsurf

kiro
structuredAttrs is enabled
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/0ryfvx3q8yhw4m37hpmj0ik1rb5jb5yb-kiro-ide-0.12.200-stable-darwin-x64.dmg
do not know how to unpack source archive /nix/store/0ryfvx3q8yhw4m37hpmj0ik1rb5jb5yb-kiro-ide-0.12.200-stable-darwin-x64.dmg

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • kiro
✅ 6 packages built:
  • antigravity-ide
  • code-cursor
  • vscode
  • vscode-with-extensions
  • vscodium
  • windsurf

kiro
structuredAttrs is enabled
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/rxxgs0kb2j95h58c8qlddqv2izqcnql1-kiro-ide-0.12.200-stable-darwin-arm64.dmg
do not know how to unpack source archive /nix/store/rxxgs0kb2j95h58c8qlddqv2izqcnql1-kiro-ide-0.12.200-stable-darwin-arm64.dmg

fhs = fhs { };
fhsWithPackages = f: fhs { additionalPkgs = f; };
fhs = (fhs { }).overrideAttrs (old: {
strictDeps = true;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just change config in pkgs/applications/editors/vscode

@schembriaiden schembriaiden May 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I get what you mean, isn't this edit in pkgs/applications/editors/vscode?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually is this actually needed? You added stucturedAtrrs and stictdeps above, doesn't fhs intherits it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually is this actually needed? You added stucturedAtrrs and stictdeps above, doesn't fhs intherits it?

Seems to fail without them:

https://github.com/NixOS/nixpkgs/actions/runs/26289931300/job/77387260084?pr=522168

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build log says this isn't the right place for this change:

       > - Attribute `pkgs.antigravity-ide-fhs` is a new package with `strictDeps` unset or set to `false`.
       >   Please enable `strictDeps = true;` in pkgs/top-level/all-packages.nix.
       >  (NPV-164)
       > - Attribute `pkgs.antigravity-ide-fhs` is a new package with `__structuredAttrs` unset or set to `false`.
       >   Please enable `__structuredAttrs = true;` in pkgs/top-level/all-packages.nix.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build log says this isn't the right place for this change:

It was like that before this request:

#522168 (comment)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a better way to inherit them in builder, without overrideAttrs. New instances of overrideAttrs shouldn't be introduced

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a better way to inherit them in builder, without overrideAttrs. New instances of overrideAttrs shouldn't be introduced

The only other way I can think of right now is adding something like this to the build-fhs-env-bubblewrap/default.nix:

    // lib.optionalAttrs (args ? strictDeps) {
      inherit (args) strictDeps;
    }
    // lib.optionalAttrs (args ? __structuredAttrs) {
      inherit (args) __structuredAttrs;
    }

I don't know if this is preferred?

@schembriaiden schembriaiden force-pushed the antigravity--rename-to-antigravity-ide branch 2 times, most recently from c37e95e to be61cfe Compare May 22, 2026 13:18
Comment thread pkgs/applications/editors/vscode/generic.nix
@schembriaiden schembriaiden force-pushed the antigravity--rename-to-antigravity-ide branch from be61cfe to f625271 Compare May 22, 2026 21:55
@BohdanTkachenko

BohdanTkachenko commented May 29, 2026

Copy link
Copy Markdown
Contributor

I gave the PR a try and hit a problem with the agent, but I think I've found the fix (using Antigravity itself) — sharing in case it's useful.

language_server_linux_x64 (the agent backend) re-execs itself inside Antigravity's own nsjail at runtime. The jail spins up a fresh mount namespace and bind-mounts only host /lib, /lib64, /usr, /bin plus every directory on $PATH — nothing else from the store. The autoPatchelfHook'd interpreter is a /nix/store glibc path that's on none of those, so it dies with:

execve('…/language_server_linux_x64'): No such file or directory

and once that's past, the agent's shell-outs fail identically: exec: "bash": executable file not found in $PATH.

With the current FHS-based packaging the agent can't run anything; every command tool call comes back as:

error executing cascade step: CORTEX_STEP_TYPE_RUN_COMMAND: read unix @ -> @: recvmsg: connection reset by peer
… failed to check terminal shell support: internal: internal error

which is the user-facing face of the execve crash above. FHS doesn't fix it because the crashing binary runs inside the nested nsjail, whose mount set is fixed (host /lib//lib64 + $PATH dirs) and which the FHS wrapper doesn't extend into — targetPkgs and the FHS /usr//lib never reach the sandboxed process. FHS can't even help indirectly: the patched interpreter is a store path, and FHS doesn't put store paths on $PATH. Since $PATH is the only thing the jail picks up from the environment, that's where the fix has to land.

Putting /nix/store on $PATH bind-mounts the whole store into the jail, so the interpreter and every tool/lib resolve with no per-binary patching:

.overrideAttrs (oldAttrs: {
  preFixup = (oldAttrs.preFixup or "") + ''
    gappsWrapperArgs+=( --prefix PATH : "/nix/store" )
  '';
})

Verified: the agent starts and its terminal runs arbitrary tools (git, jj, nix, …).

P.S. FYI the same issue affects antigravity-hub. The fix is also the same - 7b88d0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants