Skip to content

openthread-border-router: 0-unstable-2025-06-12 -> 2026.06.0#528019

Merged
NyCodeGHG merged 1 commit into
NixOS:masterfrom
JamieMagee:openthread-border-router-2026.06.0
Jun 7, 2026
Merged

openthread-border-router: 0-unstable-2025-06-12 -> 2026.06.0#528019
NyCodeGHG merged 1 commit into
NixOS:masterfrom
JamieMagee:openthread-border-router-2026.06.0

Conversation

@JamieMagee

Copy link
Copy Markdown
Member

Updates ot-br-posix to the 2026.06.0 release. Switches the mDNS backend to OpenThread's built-in publisher, since OTBR_MDNS=avahi was removed upstream. avahi and the netfilter inputs are dropped, and the NixOS module no longer enables avahi.

Things done

@nixpkgs-ci nixpkgs-ci Bot requested review from leonm1 and mrene June 4, 2026 16:15
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 4, 2026
Comment thread pkgs/by-name/op/openthread-border-router/package.nix Outdated
@JamieMagee

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 528019
Commit: 215a61ba18d0ae11e41ba588c6e2182214129817 (subsequent changes)
Merge: 02983c797a9e2f454c31b960a1d4fc4036cf0bc8

Logs: https://github.com/JamieMagee/nixpkgs-review-gha/actions/runs/26964490773


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • openthread-border-router

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • openthread-border-router

@JamieMagee JamieMagee force-pushed the openthread-border-router-2026.06.0 branch 2 times, most recently from 99bc5d6 to f9160f4 Compare June 4, 2026 16:23
@JamieMagee JamieMagee requested a review from dotlambda June 4, 2026 16:24
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 4, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 5, 2026
@JamieMagee JamieMagee force-pushed the openthread-border-router-2026.06.0 branch from f9160f4 to e7b1f5d Compare June 5, 2026 18:53
@JamieMagee

Copy link
Copy Markdown
Member Author

I fixed the lint issue.

@NyCodeGHG

Copy link
Copy Markdown
Member

Tested this PR on my setup, otbr-agent fails to start.

https://gist.github.com/NyCodeGHG/3c29d8a7ad8a9841d6a0c26f53446167

@NyCodeGHG

Copy link
Copy Markdown
Member
diff --git a/pkgs/by-name/op/openthread-border-router/package.nix b/pkgs/by-name/op/openthread-border-router/package.nix
index 134d0b3500..0d1507d9c2 100644
--- a/pkgs/by-name/op/openthread-border-router/package.nix
+++ b/pkgs/by-name/op/openthread-border-router/package.nix
@@ -90,6 +90,8 @@
     (lib.cmakeBool "OTBR_TREL" true)
 
     (lib.cmakeFeature "OTBR_VERSION" version)
+    (lib.cmakeFeature "OTBR_VENDOR_NAME" "NixOS")
+    (lib.cmakeFeature "OTBR_PRODUCT_NAME" "OpenThread Border Router")
     # OTBR_MDNS=openthread turns on the OT-core advertising and discovery proxies by default.
     # The discovery proxy gives us the DNS-SD server OTBR_DNS_UPSTREAM_QUERY needs.
     (lib.cmakeBool "OTBR_DNS_UPSTREAM_QUERY" true)

This makes it work

@NyCodeGHG

NyCodeGHG commented Jun 6, 2026

Copy link
Copy Markdown
Member

Home Assistant also can no longer find the Border Router after this update.

Caused by something else, ignore please

Comment on lines 42 to 44

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like no. I've removed it in the latest push.

@JamieMagee

Copy link
Copy Markdown
Member Author

Thanks for the tips about OTBR_VENDOR_NAME and OTBR_PRODUCT_NAME. I've added them, as well as a comment explaining why they are needed.

@JamieMagee JamieMagee force-pushed the openthread-border-router-2026.06.0 branch from e7b1f5d to 62ba9cd Compare June 6, 2026 23:25
@JamieMagee JamieMagee requested a review from NyCodeGHG June 7, 2026 03:16
@NyCodeGHG NyCodeGHG added this pull request to the merge queue Jun 7, 2026
Merged via the queue into NixOS:master with commit ae53915 Jun 7, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants