opencv4: drop gtk2 support for highgui#545459
Open
ShadowRZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #410814
OpenCV 4 highgui can build with GTK3 and also prefers it: https://docs.opencv.org/4.13.0/db/d05/tutorial_config_reference.html#tutorial_config_reference_highgui
Leaf impacted packages:
apriltags: enables both GTK2 and GTK3, will actually use GTK3 at runtime so should have no losshowdy,linux-enable-ir-emitter: all depends onpython3Packages.opencv4Full. as above the built OpenCV 4 will use GTK3, not GTK2. They also directly depends on GTK3.rPackages.opencv: I don't think this would require GTK2 in any way, and should work with GTK3 highgui.Closes #545102
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.