Skip to content

Conversation

@Conni2461
Copy link
Member

No description provided.

@Conni2461 Conni2461 mentioned this pull request Sep 2, 2025
@Conni2461 Conni2461 enabled auto-merge September 2, 2025 20:23
@wolfgangwalther
Copy link
Contributor

Oh my... wow.

Allow larger ids for CheckSuite.id deserialization

These IDs hit the 32bit limit? :D

@Conni2461 Conni2461 merged commit fe3bf30 into NixOS:released Sep 2, 2025
2 checks passed
@dasJ dasJ deleted the fix/hubcaps_parsing branch September 2, 2025 20:31
@Conni2461
Copy link
Member Author

Conni2461 commented Sep 2, 2025

These IDs hit the 32bit limit? :D

that issue was an issue for way to long, but it doesnt matter because thats the response and at this point in time the item is already created so its just a lot of spam in the logs so i fixed that one as well.

i explained the issue in the ofborg matrix channel:

for anyone interested: issue was that https://api.github.com/repos/nixos/nixpkgs/commits/{sha}/statuses returned a response which didnt parse sometimes. hubcaps expected that description to always be String, but github was returning null for some. example: curl https://api.github.com/repos/nixos/nixpkgs/commits/efd958b34fa5e157368d61c3401546e2c0bd0d15/statuses

@wolfgangwalther
Copy link
Contributor

Uh, that would have been... me, then: NixOS/nixpkgs@2c25cb0

This commit posts a new status without description. Who would have thought that I'd break ofborg with that :D

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants