Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Changes made by this pull request: .github/workflows/pytest.yml Makefile README.md nbs/docs/deployment/3_snowflake.ipynb nixtla/init.py nixtla/scripts/snowflake_install_nixtla.py nixtla_tests/snowflake/conftest.py nixtla_tests/snowflake/test_snowflake_deployment.py pyproject.toml uv.lock |
e4b84e9 to
53a8076
Compare
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
nixtla/__init__.py
Outdated
| @@ -1,3 +1,3 @@ | |||
| __version__ = "0.7.2" | |||
| __version__ = "0.7.3" | |||
There was a problem hiding this comment.
| __version__ = "0.7.3" | |
| from importlib.metadata import version | |
| __version__ = version("nixtla") |
I suggest that in the near future, we standardize the naming of version similar to what we do in the other repositories like https://github.com/Nixtla/datasetsforecast/pull/83/changes
We also need to revise pyproject.toml file
JQGoh
left a comment
There was a problem hiding this comment.
The main changes required is on the standardization of naming of release version
| elif pip_result.returncode != 0: | ||
| # No fallback available — surface the original error | ||
| pip_result.check_returncode() |
There was a problem hiding this comment.
| elif pip_result.returncode != 0: | |
| # No fallback available — surface the original error | |
| pip_result.check_returncode() | |
| pip_result.check_returncode() |
How about we always use check_returncode() regardless of the state of returncode? Per my understanding, it enforces "Does nothing if the return code is 0 (indicating success)"
2e1dcb4 to
f3ef265
Compare
f3ef265 to
78178c7
Compare
| fallback_args = ( | ||
| base_args + [fallback_package_source] + extra_deps + no_deps_flag | ||
| ) | ||
| pip_result = subprocess.run(fallback_args, check=True) |
There was a problem hiding this comment.
We need fallback approach when the package cannot be found in the package repository.





Key Changes:
pyproject.toml(similar to [CHORE] Version bump for release datasetsforecast#83)ruffto dev dependenciespackage_and_upload_nixtlato handle the case when thenixtlaclient with the specified version has not been published