fix: support Polars Float32 in cross-validation with finetuning#751
Open
W057 wants to merge 1 commit intoNixtla:mainfrom
Open
fix: support Polars Float32 in cross-validation with finetuning#751W057 wants to merge 1 commit intoNixtla:mainfrom
W057 wants to merge 1 commit intoNixtla:mainfrom
Conversation
Polars Float32 columns produce read-only numpy arrays when converted. np.nan_to_num with copy=False attempts in-place modification on these read-only arrays, causing ValueError during cross-validation with finetuning. Closes Nixtla#635
W057
force-pushed
the
fix/issue-635-polars-float32-copy
branch
from
2d76ce7 to
e9706eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorwhen running cross-validation with finetuning on Polars DataFrames with Float32 targetsnp.nan_to_numwithcopy=Falsetries to modify them in-place, which failscopy=Falsetocopy=Trueinensure_contiguous_if_array()(line 897)As suggested by @jmoralez in #635.
Closes #635