refactor/getty #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No-SilverBullet
commented
Dec 20, 2024
pkg/client/client.go
Outdated
| // initRemoting init remoting | ||
| func initRemoting(cfg *Config) { | ||
| getty.InitRpcClient(&cfg.GettyConfig, &remoteConfig.SeataConfig{ | ||
| SeataConfig := remoteConfig.SeataConfig{ |
Owner
Author
There was a problem hiding this comment.
should be lowercase , change to seataConfig := xxx
pkg/remoting/getty/getty_remoting.go
Outdated
| mergeMsgMap: &sync.Map{}, | ||
| } | ||
| }) | ||
| func NewGettyRemoting() *GettyRemoting { |
Owner
Author
There was a problem hiding this comment.
NewGettyRemoting -> newGettyRemoting 包外不能访问
Collaborator
There was a problem hiding this comment.
已将 NewGettyRemoting 改为 newGettyRemoting，限制包外访问
Comment on lines
55
to
57
| func initSessionManager(gettyConfig *config.Config, seataConfig *config.SeataConfig) { | ||
| sessionManager = &SessionManager{ | ||
| allSessions: sync.Map{}, |
Owner
Author
There was a problem hiding this comment.
用sync.Once保证只初始化一次会不会好一点
|
|
||
| func (f *clientOnResponseProcessor) Process(ctx context.Context, rpcMessage message.RpcMessage) error { | ||
| log.Infof("the rm client received clientOnResponse msg %#v from tc server.", rpcMessage) | ||
| client := getty.GetGettyRemotingClient() |
Owner
Author
There was a problem hiding this comment.
client 换个名字，不是很清晰的一个命名，maybe gettyClient or something else
Collaborator
There was a problem hiding this comment.
改进了变量命名，将 client 改为更明确的 gettyRemotingClient
pkg/remoting/getty/listener.go
Outdated
Comment on lines
42
to
43
| msgFutures *sync.Map | ||
| mergeMsgMap *sync.Map |
Owner
Author
There was a problem hiding this comment.
我记得这两个好像没用，讨论的时候说是不是可以删除掉
Collaborator
There was a problem hiding this comment.
移除了 gettyClientHandler 中未使用的 msgFutures 和 mergeMsgMap 字段
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: