Add additional integrations tests for libraries that use splint

Author: NoahTheDuke

CHANGELOG.md

@@ -18,6 +18,7 @@ This changelog is loose. Versions are not semantic, they are incremental. Splint
 - New config option for `lint/fn-wrapper`: `:names-to-skip`. Given that many macros require wrapping, skipping them (or any other calls) can be configured with `:names-to-skip`, which takes a vector of simple symbols to skip during analysis. For example, `lint/fn-wrapper {:names-to-skip [inspect]}` will not trigger on `(add-tap (fn [x] (morse/inspect)))`.
 - New config option for `style/redundant-nested-call`: `:fn-names`. By default, `style/redundant-nested-call` only checks a handful of `clojure.core` vars. To check against custom functions, add them to the config with `style/redundant-nested-call {:fn-names [foo bar]}`.
 - Rules support `:config-coercer`, a one-arg function that takes the final result of a rules' processed config and should return it. Allows for rules to define custom ways of handling config data before it's used (such as unifying args). See `lint/catch-throwable` for an example.
+- DEV ONLY: add roughly 10 new integrations tests for github repos that already rely on Splint.
 
 ### Changed
 

test/noahtheduke/splint/integrations/clj_auth_test.clj

@@ -0,0 +1,55 @@
+; This Source Code Form is subject to the terms of the Mozilla Public
+; License, v. 2.0. If a copy of the MPL was not distributed with this
+; file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
+(ns noahtheduke.splint.integrations.clj-auth-test
+  {:integration true}
+  (:require
+   [clojure.tools.gitlibs :as gl]
+   [lazytest.core :refer [defdescribe expect it]]
+   [lazytest.extensions.matcher-combinators :refer [match?]]
+   [matcher-combinators.matchers :as m]
+   [noahtheduke.splint.clojure-ext.core :refer [update-vals*]]
+   [noahtheduke.splint.integrations.helpers :refer [usefully-enabled-config]]
+   [noahtheduke.splint.runner :refer [run-impl]]))
+
+(set! *warn-on-reflection* true)
+
+(def clj-auth-diagnostics
+  '{lint/defmethod-names 7
+    lint/fn-wrapper 1
+    lint/if-not-both 1
+    lint/redundant-str-call 3
+    lint/warn-on-reflection 19
+    metrics/fn-length 17
+    performance/dot-equals 27
+    performance/single-literal-merge 7
+    style/is-eq-order 6})
+
+(defdescribe clj-auth-test
+  (let [clj-auth (delay (gl/procure "https://github.com/theophilusx/clj-auth.git"
+                          'theophilusx/clj-auth "4fbbf8222d92227c821c3db34c75a45d6e540185"))
+        results (delay
+                  (run-impl [{:path @clj-auth}]
+                            {:config-override
+                             (-> (usefully-enabled-config)
+                                 (assoc :silent true)
+                                 (assoc :parallel false)
+                                 (assoc :clojure-version {:major 1 :minor 11}))}))
+        diagnostics (delay (->> @results
+                                :diagnostics
+                                (group-by :rule-name)
+                                (into (sorted-map))))]
+    ; (user/pprint (dissoc @diagnostics 'lint/warn-on-reflection))
+    ; (user/pprint (into (sorted-map) (update-vals* @diagnostics count)))
+    (it "has the right diagnostics"
+      (expect
+        (match?
+         (m/equals clj-auth-diagnostics)
+         (update-vals* @diagnostics count))))
+    (it "sums correctly"
+      (expect (= 88 (count (:diagnostics @results)))))
+    (it "raises no errors"
+      (expect (nil? (get diagnostics 'splint/error))))
+    (it "raises no unknown errors"
+      (expect (nil? (get diagnostics 'splint/unknown-error))))))

test/noahtheduke/splint/integrations/clj_kondo_test.clj

@@ -3,108 +3,87 @@
 ; file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
 (ns noahtheduke.splint.integrations.clj-kondo-test
+  {:integration true}
   (:require
    [clojure.tools.gitlibs :as gl]
    [lazytest.core :refer [defdescribe expect it]]
    [lazytest.extensions.matcher-combinators :refer [match?]]
-   [noahtheduke.splint.clojure-ext.core :refer [update-vals*]]
    [matcher-combinators.matchers :as m]
-   [noahtheduke.splint.config :refer [default-config]]
+   [noahtheduke.splint.clojure-ext.core :refer [update-vals*]]
+   [noahtheduke.splint.integrations.helpers :refer [usefully-enabled-config]]
    [noahtheduke.splint.runner :refer [run-impl]]))
 
 (set! *warn-on-reflection* true)
 
-(def all-enabled-config
-  (-> @default-config
-      (update-vals* #(assoc % :enabled true))
-      (assoc-in ['style/set-literal-as-fn :enabled] false)))
-
 (def clj-kondo-diagnostics
   '{lint/assoc-fn 1
-    lint/body-unquote-splicing 2
-    lint/catch-throwable 4
-    lint/defmethod-names 63
+    lint/catch-throwable 6
+    lint/defmethod-names 6
     lint/dot-class-method 2
-    lint/dot-obj-method 1
     lint/fn-wrapper 1
-    lint/identical-branches 9
-    lint/if-else-nil 42
-    lint/if-let-else-nil 2
-    lint/if-nil-else 2
-    lint/if-not-both 3
-    lint/let-if 8
-    lint/let-when 2
-    lint/misplaced-type-hint 10
-    lint/missing-body-in-when 2
+    lint/identical-branches 2
+    lint/if-else-nil 1
+    lint/if-nil-else 1
+    lint/if-not-both 2
+    lint/let-if 3
+    lint/let-when 1
+    lint/missing-body-in-when 1
     lint/no-catch 1
-    lint/no-op-assignment 2
-    lint/prefer-require-over-use 4
-    lint/redundant-str-call 18
-    lint/thread-macro-one-arg 85
-    lint/try-splicing 2
-    lint/underscore-in-namespace 1
-    lint/warn-on-reflection 229
-    metrics/fn-length 314
-    metrics/parameter-count 48
-    naming/conventional-aliases 14
-    naming/conversion-functions 2
-    naming/lisp-case 3
-    naming/predicate 2
+    lint/no-op-assignment 3
+    lint/redundant-str-call 1
+    lint/thread-macro-one-arg 70
+    lint/try-splicing 3
+    lint/warn-on-reflection 112
+    metrics/fn-length 227
+    metrics/parameter-count 32
+    naming/conventional-aliases 5
     naming/record-name 1
-    naming/single-segment-namespace 80
-    performance/assoc-many 80
-    performance/avoid-satisfies 2
-    performance/dot-equals 123
-    performance/get-keyword 14
-    performance/single-literal-merge 9
-    splint/parsing-error 4
-    style/apply-str 14
-    style/apply-str-interpose 3
-    style/cond-else 5
-    style/def-fn 3
-    style/eq-false 2
-    style/eq-true 5
-    style/eq-zero 2
-    style/is-eq-order 27
+    performance/assoc-many 91
+    performance/dot-equals 83
+    performance/get-keyword 12
+    performance/single-literal-merge 2
+    style/apply-str 1
+    style/apply-str-interpose 1
+    style/eq-true 3
     style/multiple-arity-order 1
-    style/neg-checks 7
-    style/new-object 5
+    style/neg-checks 1
+    style/new-object 4
     style/not-eq 3
-    style/not-nil? 12
     style/not-some-pred 2
-    style/plus-one 4
     style/pos-checks 1
-    style/prefer-clj-string 18
-    style/prefer-condp 3
-    style/prefer-vary-meta 6
-    style/prefixed-libspecs 9
-    style/redundant-let 6
-    style/redundant-nested-call 6
-    style/single-key-in 2
-    style/tostring 4
-    style/useless-do 6
-    style/when-do 1
-    style/when-not-call 15
-    style/when-not-do 1})
+    style/prefer-clj-string 5
+    style/prefer-condp 2
+    style/prefer-vary-meta 2
+    style/single-key-in 1
+    style/tostring 2
+    style/useless-do 2
+    style/when-not-call 12})
 
-(defdescribe ^:integration clj-kondo-test
-  (let [clj-kondo (delay (gl/procure "https://github.com/clj-kondo/clj-kondo.git" 'clj-kondo/clj-kondo "v2023.05.26"))
+(defdescribe clj-kondo-test
+  (let [clj-kondo (delay (gl/procure "https://github.com/clj-kondo/clj-kondo.git"
+                           'clj-kondo/clj-kondo "v2025.06.05"))
         results (delay
-                  (run-impl [{:path @clj-kondo}]
+                  (run-impl [{:path (str @clj-kondo "/src")}
+                             {:path (str @clj-kondo "/test")}]
                             {:config-override
-                             (-> all-enabled-config
+                             (-> (usefully-enabled-config)
                                  (assoc :silent true)
                                  (assoc :parallel false)
                                  #_(assoc :autocorrect true)
                                  (assoc :clojure-version {:major 1 :minor 11}))}))
         diagnostics (delay (->> @results
                                 :diagnostics
                                 (group-by :rule-name)))]
-    ; (user/pprint (get @diagnostics 'lint/no-op-assignment))
+    ; (user/pprint (into (sorted-map) (dissoc @diagnostics 'lint/warn-on-reflection 'lint/defmethod-names)))
+    ; (user/pprint (into (sorted-map) (update-vals* @diagnostics count)))
     (it "has the right diagnostics"
       (expect
         (match?
          (m/equals clj-kondo-diagnostics)
          (update-vals* @diagnostics count))))
     (it "sums correctly"
-      (expect (= 1365 (count (:diagnostics @results)))))))
+      (expect (= 713 (count (:diagnostics @results)))))
+    (it "raises no errors"
+      (expect (nil? (get diagnostics 'splint/error))))
+    (it "raises no unknown errors"
+      (expect (nil? (get diagnostics 'splint/unknown-error))))))

test/noahtheduke/splint/integrations/dinero_test.clj

@@ -0,0 +1,52 @@
+; This Source Code Form is subject to the terms of the Mozilla Public
+; License, v. 2.0. If a copy of the MPL was not distributed with this
+; file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
+(ns noahtheduke.splint.integrations.dinero-test
+  {:integration true}
+  (:require
+   [clojure.tools.gitlibs :as gl]
+   [lazytest.core :refer [defdescribe expect it]]
+   [lazytest.extensions.matcher-combinators :refer [match?]]
+   [matcher-combinators.matchers :as m]
+   [noahtheduke.splint.clojure-ext.core :refer [update-vals*]]
+   [noahtheduke.splint.integrations.helpers :refer [usefully-enabled-config]]
+   [noahtheduke.splint.runner :refer [run-impl]]))
+
+(set! *warn-on-reflection* true)
+
+(def dinero-diagnostics
+  '{lint/defmethod-names 25
+    lint/identical-branches 2
+    lint/warn-on-reflection 14
+    metrics/fn-length 8
+    metrics/parameter-count 5
+    performance/assoc-many 1
+    performance/dot-equals 29})
+
+(defdescribe dinero-test
+  (let [dinero (delay (gl/procure "https://github.com/sernamar/dinero.git" 'com.sernamar/dinero "v0.3.0"))
+        results (delay
+                  (run-impl [{:path @dinero}]
+                            {:config-override
+                             (-> (usefully-enabled-config)
+                                 (assoc :silent true)
+                                 (assoc :parallel false)
+                                 (assoc :clojure-version {:major 1 :minor 11}))}))
+        diagnostics (delay (->> @results
+                                :diagnostics
+                                (group-by :rule-name)
+                                (into (sorted-map))))]
+    ; (user/pprint (dissoc @diagnostics 'lint/warn-on-reflection))
+    ; (user/pprint (into (sorted-map) (update-vals* @diagnostics count)))
+    (it "has the right diagnostics"
+      (expect
+        (match?
+         (m/equals dinero-diagnostics)
+         (update-vals* @diagnostics count))))
+    (it "sums correctly"
+      (expect (= 84 (count (:diagnostics @results)))))
+    (it "raises no errors"
+      (expect (nil? (get diagnostics 'splint/error))))
+    (it "raises no unknown errors"
+      (expect (nil? (get diagnostics 'splint/unknown-error))))))

test/noahtheduke/splint/integrations/env_logger_test.clj

@@ -0,0 +1,52 @@
+; This Source Code Form is subject to the terms of the Mozilla Public
+; License, v. 2.0. If a copy of the MPL was not distributed with this
+; file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
+(ns noahtheduke.splint.integrations.env-logger-test
+  {:integration true}
+  (:require
+   [clojure.tools.gitlibs :as gl]
+   [lazytest.core :refer [defdescribe expect it]]
+   [lazytest.extensions.matcher-combinators :refer [match?]]
+   [matcher-combinators.matchers :as m]
+   [noahtheduke.splint.clojure-ext.core :refer [update-vals*]]
+   [noahtheduke.splint.integrations.helpers :refer [usefully-enabled-config]]
+   [noahtheduke.splint.runner :refer [run-impl]]))
+
+(set! *warn-on-reflection* true)
+
+(def env-logger-diagnostics
+  '{lint/warn-on-reflection 15
+    metrics/fn-length 40
+    performance/assoc-many 1
+    performance/dot-equals 30
+    performance/single-literal-merge 9
+    style/prefixed-libspecs 14})
+
+(defdescribe env-logger-test
+  (let [env-logger (delay (gl/procure "https://github.com/terop/env-logger.git"
+                          'terop/env-logger "1a82add79ae93ed5d935192a6261eb83c19dc0df"))
+        results (delay
+                  (run-impl [{:path @env-logger}]
+                            {:config-override
+                             (-> (usefully-enabled-config)
+                                 (assoc :silent true)
+                                 (assoc :parallel false)
+                                 (assoc :clojure-version {:major 1 :minor 11}))}))
+        diagnostics (delay (->> @results
+                                :diagnostics
+                                (group-by :rule-name)
+                                (into (sorted-map))))]
+    ; (user/pprint (dissoc @diagnostics 'lint/warn-on-reflection))
+    ; (user/pprint (into (sorted-map) (update-vals* @diagnostics count)))
+    (it "has the right diagnostics"
+      (expect
+        (match?
+         (m/equals env-logger-diagnostics)
+         (update-vals* @diagnostics count))))
+    (it "sums correctly"
+      (expect (= 109 (count (:diagnostics @results)))))
+    (it "raises no errors"
+      (expect (nil? (get diagnostics 'splint/error))))
+    (it "raises no unknown errors"
+      (expect (nil? (get diagnostics 'splint/unknown-error))))))

test/noahtheduke/splint/integrations/helpers.clj

@@ -0,0 +1,15 @@
+; This Source Code Form is subject to the terms of the Mozilla Public
+; License, v. 2.0. If a copy of the MPL was not distributed with this
+; file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
+(ns noahtheduke.splint.integrations.helpers 
+  (:require
+   [noahtheduke.splint.clojure-ext.core :refer [update-vals*]]
+   [noahtheduke.splint.config :refer [read-default-config]]))
+
+(set! *warn-on-reflection* true)
+
+(defn usefully-enabled-config []
+  (-> (read-default-config)
+      (update-vals* #(assoc % :enabled true))
+      (assoc-in ['style/set-literal-as-fn :enabled] false)))