Use new get_radio_mix for Track and Artist #118
Conversation
Nokse22
force-pushed
the
nokse/use-radio-mix
branch
from
5767365 to
ff00e65
Compare
Nokse22
requested review from
drafolin and
nilathedragon
and removed request for
drafolin
|
Does 0.8.5 work with this? And does 0.8.5 load the home page? |
| if parameter.get_string() == "": | ||
| return |
There was a problem hiding this comment.
In case the parameter of the action is empty it will not try to load the page with an empty id.
There was a problem hiding this comment.
In case the parameter of the action is empty
does that ever actually happen? and if it happens, will it pop off the stack or will it just load a blank page?
Yes and yes. |
|
For tracks that have a radio available, this seems to work. Artists too. Homepage is not loading for me, checking which tidal package version I have... |
|
Exception "Item type 'DEEP_LINK' not implemented" |
|
It is on 0.8.5 but probably not related to this PR specifically. |
this got fixed upstream in the upcoming release I believe |
Yes, Then I'd merge this |
|
I saw 0.8.6 was released, testing that... |
It works for me |
|
works with 0.8.6 for me; will adapt pkgbuilds |
|
Works indee, will update nixpkgs |
This needs
python-tidal >= v0.8.4, but now this version doesn't load the home page