-
-
Notifications
You must be signed in to change notification settings - Fork 38
ALSA device setting for exclusive hw access #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The sink also does not seem to reload cleanly, but I think that is out of our control. Playing a new thing fixes it. |
89e5383 to
c63cb5f
Compare
c63cb5f to
2acd07a
Compare
|
To make the setting disabled when ALSA is not used you need to connect to |
|
@Nokse22 The ALSA sink seems really sensitive towards device disconnects etc. Do you think a simple toast message would be enough? |
|
I noticed there are a few bugs when switching between ALSA and pipewire. Most of these are avoided by playing a new thing. But when I do it in code, it won't work. I think it is too fast. |
|
@Nokse22 Fixed the errors. It is working now. |
|
I also thaught about directly calling aplay -l because it also gives for example HDMI port info and connected device info, making it easier to differentiate between alsa devices. What are your thoughts on this @Nokse22? Sadly, it's not in the flatpak runtime. |
|
Never mind, I just added it with a fallback option if aplay is not installed. 😅 |
Good, I was going to say to add it to the flatpak! |
|
Did that already. Was pretty time consuming because alsa-utils tries to install files to /lib/udev. I just moved them somewhere else. Does not seem to matter for aplay. |
|
I don't know, I tested it and it seems to work fine, but I don't have the hardware to test this properly. But since it should not affect users if not playing using ALSA it fine to merge for me. |
Should fix #115
I would still like to make the setting not selectable if ALSA is not set as a sink. @Nokse22 do you have an idea how?
And I did not figure out how to re-add the tickmark after I changed the ComboRow Factory to set max_charater_width like in https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/3169 It seems to work without it 🤷♂️