Skip to content

Conversation

@Plamper
Copy link
Collaborator

@Plamper Plamper commented Aug 20, 2025

Should fix #115

I would still like to make the setting not selectable if ALSA is not set as a sink. @Nokse22 do you have an idea how?

And I did not figure out how to re-add the tickmark after I changed the ComboRow Factory to set max_charater_width like in https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/3169 It seems to work without it 🤷‍♂️

@Plamper Plamper requested a review from Nokse22 August 20, 2025 15:40
@Plamper
Copy link
Collaborator Author

Plamper commented Aug 20, 2025

The sink also does not seem to reload cleanly, but I think that is out of our control. Playing a new thing fixes it.

@Plamper Plamper force-pushed the exclusive-mode branch 2 times, most recently from 89e5383 to c63cb5f Compare August 22, 2025 11:43
@Nokse22
Copy link
Owner

Nokse22 commented Aug 22, 2025

To make the setting disabled when ALSA is not used you need to connect to notify::selected-item signal of the sink ComboRow then set the new row sensitive property in the signal handler

@Plamper
Copy link
Collaborator Author

Plamper commented Aug 22, 2025

@Nokse22 The ALSA sink seems really sensitive towards device disconnects etc. Do you think a simple toast message would be enough?

@Plamper
Copy link
Collaborator Author

Plamper commented Aug 22, 2025

I noticed there are a few bugs when switching between ALSA and pipewire. Most of these are avoided by playing a new thing. But when I do it in code, it won't work. I think it is too fast.

@Plamper
Copy link
Collaborator Author

Plamper commented Aug 22, 2025

@Nokse22 Fixed the errors. It is working now.

@Plamper
Copy link
Collaborator Author

Plamper commented Aug 22, 2025

I also thaught about directly calling aplay -l because it also gives for example HDMI port info and connected device info, making it easier to differentiate between alsa devices. What are your thoughts on this @Nokse22? Sadly, it's not in the flatpak runtime.

@Plamper
Copy link
Collaborator Author

Plamper commented Aug 22, 2025

Never mind, I just added it with a fallback option if aplay is not installed. 😅

@Nokse22
Copy link
Owner

Nokse22 commented Aug 23, 2025

Never mind, I just added it with a fallback option if aplay is not installed. 😅

Good, I was going to say to add it to the flatpak!

@Plamper
Copy link
Collaborator Author

Plamper commented Aug 23, 2025

Did that already. Was pretty time consuming because alsa-utils tries to install files to /lib/udev. I just moved them somewhere else. Does not seem to matter for aplay.

@Nokse22
Copy link
Owner

Nokse22 commented Aug 23, 2025

I don't know, I tested it and it seems to work fine, but I don't have the hardware to test this properly. But since it should not affect users if not playing using ALSA it fine to merge for me.

@Plamper Plamper merged commit 45da15d into Nokse22:master Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclusive Mode

2 participants