refactor(provider): introduce ObservedExecution to encapsulate EVM observer lifecycle

[anaPerezGhiglia]

Context

While implementing gas estimation improvements (#1455), several structural issues in the existing code became apparent: the EVM observer lifecycle was repeated manually at every call site, and estimate_gas logic was spread across data.rs rather than living in gas.rs alongside its helpers. This PR addresses those improvements independently to avoid mixing concerns and enable focused review

Changes

Introduces ObservedExecution<T> and observe_execution in observability.rs to encapsulate the observer lifecycle (create → run → collect_and_report), replacing the manual pattern repeated at every EVM call site.

Key changes:

• observe_execution wraps observer creation and collection into a single call
• ObservedExecution::into_result_and_traces provides a consuming accessor for the execution result and filtered call traces
• EvmObservedData::into_call_traces / CallResultWithMetadata::into_call_traces are consuming filter methods that replace inline if/else blocks
• estimate_gas is moved from data.rs into gas.rs, with check_gas_limit and binary_search_estimation refactored to take a shared Context struct; this also eliminates the one call_trace_arena.clone() that existed in the previous implementation

[changeset-bot]

⚠️ No Changeset found

Latest commit: cd28569

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Copilot]

Pull request overview

This PR refactors EDR provider EVM observability and gas estimation flow by introducing an ObservedExecution<T> wrapper and observe_execution helper to centralize the EVM observer lifecycle (create → execute → collect/report), while also relocating estimate_gas into data/gas.rs alongside its helpers.

Changes:

• Added observe_execution + ObservedExecution<T> to standardize EVM observer lifecycle handling and trace extraction.
• Introduced consuming “filter-to-traces” helpers (EvmObservedData::into_call_traces, CallResultWithMetadata::into_call_traces) to replace repeated inline if include_call_traces { ... } blocks.
• Moved/refactored estimate_gas into data/gas.rs and introduced a shared Context to reduce duplication and avoid unnecessary cloning.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/edr_provider/src/requests/hardhat/miner.rs	Refactors call trace extraction to use EvmObservedData::into_call_traces.
crates/edr_provider/src/requests/eth/evm.rs	Refactors call trace extraction to use EvmObservedData::into_call_traces.
crates/edr_provider/src/observability.rs	Introduces ObservedExecution<T> and observe_execution to encapsulate observer lifecycle and filtered trace retrieval.
crates/edr_provider/src/debug_trace.rs	Switches debug tracing flow to use observe_execution and into_result_and_traces.
crates/edr_provider/src/data/gas.rs	Moves/refactors gas estimation into gas.rs with shared Context and observer lifecycle consolidation.
crates/edr_provider/src/data.rs	Adopts observe_execution at call sites, adds conversion from ObservedExecution to CallResultWithMetadata, and delegates gas estimation into gas.rs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 92.30769% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.37%. Comparing base (bccd377) to head (cd28569).

Files with missing lines	Patch %	Lines
crates/edr_provider/src/data/gas.rs	87.71%	9 Missing and 5 partials ⚠️
crates/edr_provider/src/data.rs	97.01%	0 Missing and 2 partials ⚠️
crates/edr_provider/src/observability.rs	95.91%	0 Missing and 2 partials ⚠️
crates/edr_provider/src/debug_trace.rs	92.85%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
+ Coverage   79.34%   79.37%   +0.02%     
==========================================
  Files         445      445              
  Lines       76465    76480      +15     
  Branches    76465    76480      +15     
==========================================
+ Hits        60673    60707      +34     
+ Misses      13660    13651       -9     
+ Partials     2132     2122      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Wodann]

Thanks for simplifying the code. I have one major concern, re. performance impact of the change.