fix(deps): enable regex unicode-perl feature at the workspace level#1466
Conversation
edr_rpc_client's URL_REGEX (API-key redaction in RPC error messages) uses a Unicode word boundary (\b), which requires regex's unicode-perl feature to build its NFA. The workspace pins regex with default-features = false, so that feature is only present when feature unification in a larger build pulls it in transitively. In the unified workspace build (and CI) it is on, so the regex builds fine. But building edr_rpc_client in isolation (cargo test -p edr_rpc_client) leaves regex featureless and URL_REGEX panics at first use with 'error building NFA'. This is invisible to cargo-hack, which only runs check (no test execution, --no-dev-deps). Declare the feature at the workspace level rather than per-crate, matching the existing serde_json precedent, so isolated builds match feature-unified ones. The regex pattern is left unchanged.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
- Coverage 79.32% 79.31% -0.01%
==========================================
Files 445 445
Lines 76416 76416
Branches 76416 76416
==========================================
- Hits 60614 60610 -4
- Misses 13678 13680 +2
- Partials 2124 2126 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Explicit
unicode-perlfeature enabled forregexpackage, as otherwisecargo test -p edr_rpc_clientfails locally.Claude summary
edr_rpc_client's URL_REGEX (API-key redaction in RPC error messages) uses a Unicode word boundary (\b), which requires regex's unicode-perl feature to build its NFA. The workspace pins regex with default-features = false, so that feature is only present when feature unification in a larger build pulls it in transitively.
In the unified workspace build (and CI) it is on, so the regex builds fine. But building edr_rpc_client in isolation (cargo test -p edr_rpc_client) leaves regex featureless and URL_REGEX panics at first use with 'error building NFA'. This is invisible to cargo-hack, which only runs check (no test execution, --no-dev-deps).
Declare the feature at the workspace level rather than per-crate, matching the existing serde_json precedent, so isolated builds match feature-unified ones. The regex pattern is left unchanged.