Skip to content

fix(deps): enable regex unicode-perl feature at the workspace level#1466

Merged
Wodann merged 1 commit into
mainfrom
fix/url-regex-unicode-independence
Jun 9, 2026
Merged

fix(deps): enable regex unicode-perl feature at the workspace level#1466
Wodann merged 1 commit into
mainfrom
fix/url-regex-unicode-independence

Conversation

@nebasuke

@nebasuke nebasuke commented Jun 8, 2026

Copy link
Copy Markdown
Member

Explicit unicode-perl feature enabled for regex package, as otherwise cargo test -p edr_rpc_client fails locally.

Claude summary

edr_rpc_client's URL_REGEX (API-key redaction in RPC error messages) uses a Unicode word boundary (\b), which requires regex's unicode-perl feature to build its NFA. The workspace pins regex with default-features = false, so that feature is only present when feature unification in a larger build pulls it in transitively.

In the unified workspace build (and CI) it is on, so the regex builds fine. But building edr_rpc_client in isolation (cargo test -p edr_rpc_client) leaves regex featureless and URL_REGEX panics at first use with 'error building NFA'. This is invisible to cargo-hack, which only runs check (no test execution, --no-dev-deps).

Declare the feature at the workspace level rather than per-crate, matching the existing serde_json precedent, so isolated builds match feature-unified ones. The regex pattern is left unchanged.

edr_rpc_client's URL_REGEX (API-key redaction in RPC error messages) uses a
Unicode word boundary (\b), which requires regex's unicode-perl feature to
build its NFA. The workspace pins regex with default-features = false, so that
feature is only present when feature unification in a larger build pulls it in
transitively.

In the unified workspace build (and CI) it is on, so the regex builds fine. But
building edr_rpc_client in isolation (cargo test -p edr_rpc_client) leaves regex
featureless and URL_REGEX panics at first use with 'error building NFA'. This is
invisible to cargo-hack, which only runs check (no test execution, --no-dev-deps).

Declare the feature at the workspace level rather than per-crate, matching the
existing serde_json precedent, so isolated builds match feature-unified ones.
The regex pattern is left unchanged.
@nebasuke nebasuke temporarily deployed to github-action-benchmark June 8, 2026 11:45 — with GitHub Actions Inactive
@changeset-bot

changeset-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fdcbe7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nebasuke nebasuke added the no changeset needed This PR doesn't require a changeset label Jun 8, 2026
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.31%. Comparing base (7e5b68b) to head (fdcbe7b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
- Coverage   79.32%   79.31%   -0.01%     
==========================================
  Files         445      445              
  Lines       76416    76416              
  Branches    76416    76416              
==========================================
- Hits        60614    60610       -4     
- Misses      13678    13680       +2     
- Partials     2124     2126       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nebasuke nebasuke temporarily deployed to github-action-benchmark June 8, 2026 12:11 — with GitHub Actions Inactive
@nebasuke nebasuke temporarily deployed to github-action-benchmark June 8, 2026 12:11 — with GitHub Actions Inactive
@nebasuke nebasuke marked this pull request as ready for review June 8, 2026 12:37
@nebasuke nebasuke requested a review from a team June 8, 2026 12:38
@Wodann Wodann added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit 3d446c9 Jun 9, 2026
53 of 54 checks passed
@Wodann Wodann deleted the fix/url-regex-unicode-independence branch June 9, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changeset needed This PR doesn't require a changeset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants