This repository was archived by the owner on Oct 8, 2025. It is now read-only.
fix serialization of bigints in transacitons command #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
suggested changes
Nov 20, 2024
Member
kanej
left a comment
kanej
left a comment
There was a problem hiding this comment.
Lets add a test explicitly for bigints in the parameters of a transaction.
To ensure we work with nested parameters we use a replacer function on stringify, rather than swapping out individual params.
kanej
force-pushed
the
fix/bigint-txs
branch
from
b4529a9 to
af1f34b
Compare
kanej
approved these changes
Nov 21, 2024
Member
kanej
left a comment
kanej
left a comment
There was a problem hiding this comment.
I think we could consider exploring other ways of out putting the params in the future rather than stringify. We convert bigints to strings here in a way that may be un-intuitive to users.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #830