-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: set up codecov for the hardhat repository #6502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
galargh
wants to merge
21
commits into
v-next
Choose a base branch
from
codecov-setup
base: v-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bae8a8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no changeset needed
This PR doesn't require a changeset
status:ready
This issue is ready to be worked on
v-next
A Hardhat v3 development task
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is to be reviewed synchronously on a call.
Warning
Instrumenting the code for coverage (lcov) can have a significant effect on CI job runtime. We should take that into account when reviewing the PR together. Below, you'll find a table with job runtimes with both lcov and junit report generation, just junit report generation and no report generation. The packages affected the most are
hardhat-keystore
andhardhat
.This PR sets up Codecov for the Hardhat repository. It will allow us to track the following over time:
The Codecov integration will also comment on PRs highlighting the changes to the above metrics in relation to the target branch.
TODO
hardhat
repositoryDefault Branch / Branch Context
tov-next
in Codecov Repository ConfigurationCODECOV_TOKEN
from the Codecov Repository ConfigurationCODECOV_TOKEN
secret to the Repository Secretscodecov.yml
to themain
branch (?) - I'm not 100% sure it's needed, let's try without it first*Alternatively, we can set up the CODECOV_TOKEN for the entire organization by copying it from the Codecov Organization Configuration and adding the
CODECOV_TOKEN
secret to the Organization SecretsThis PR has been originally created #6449