Skip to content

Add detailed logging to SenderProvider and AutomaticSenderProvider #6675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

demoncoder-crypto
Copy link

Addresses #6632. I will iteratively fix everything if the said implementation is up to expectation

Copy link

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: 34054c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alcuadrado
Copy link
Member

Hey, do you mind explaining this PR?

@demoncoder-crypto
Copy link
Author

demoncoder-crypto commented May 19, 2025

The changes introduce detailed console logging within:

  1. -SenderProvider.request(): To trace how requests are processed and when the provider attempts to determine a sender.

2)- AutomaticSenderProvider._getSender(): To observe the logic for fetching a sender, including cache hits/misses and the explicit call to eth_accounts. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants