Skip to content

Fixes and improvements to benchmarks#1736

Merged
teofr merged 3 commits into
mainfrom
teofr/run-v2-benchmarks
Jun 5, 2026
Merged

Fixes and improvements to benchmarks#1736
teofr merged 3 commits into
mainfrom
teofr/run-v2-benchmarks

Conversation

@teofr

@teofr teofr commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Some improvements to the benchmarks pipelines:

  • Since V2 benchmarks are quick (~10min) and it's important not to regress in V2 it makes sense to run them on all PRs.
  • Since callgrind benchmarks are so stable, we can use a window of 1, it also means after a regressing PR (that maybe we've accepted) the next PRs won't complain about it)
  • Since the base sha in GH actions is problematic, we compare against the HEAD of the target branch, it's likely better.

@changeset-bot

changeset-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a7c093b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchteofr/run-v2-benchmarks
Testbedci

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

🚨 3 Alerts

🐰 View full continuous benchmarking report in Bencher

@teofr teofr changed the title Run V2 benchmarks in all PRs Fixes and improvements to benchmarks Apr 30, 2026
@teofr

teofr commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

This PR is failing due to bencherdev/bencher#818, the fix is already merged but hasn't landed on bencher.dev

I'll mark it ready to review once that's done

@teofr teofr force-pushed the teofr/run-v2-benchmarks branch from 75f1ee2 to fb6606c Compare May 6, 2026 12:24
@teofr teofr force-pushed the teofr/run-v2-benchmarks branch from fb6606c to ed16453 Compare May 18, 2026 13:14
@teofr teofr force-pushed the teofr/run-v2-benchmarks branch from ed16453 to a7c093b Compare May 19, 2026 08:47
@teofr teofr marked this pull request as ready for review May 19, 2026 11:28
@teofr teofr requested review from a team as code owners May 19, 2026 11:28

@nebasuke nebasuke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@teofr teofr added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 9c2563a Jun 5, 2026
16 checks passed
@teofr teofr deleted the teofr/run-v2-benchmarks branch June 5, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants