Skip to content

[v2] fix common and mobile type mechanism #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teofr merged 4 commits into from
May 27, 2026
Merged

[v2] fix common and mobile type mechanism #1792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd9cfd8
fix common type, delay mobile
teofr May 22, 2026
9673de4
Addressed comments, big refactor
teofr May 26, 2026
7e725cd
Update crates/solidity-v2/outputs/cargo/semantic/src/types/registry.rs
teofr May 26, 2026
918189d
Update crates/solidity-v2/outputs/cargo/semantic/src/passes/tests/typ…
teofr May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/solidity-v2/outputs/cargo/semantic/src/passes/p4_resolve_references/typing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ impl Pass<'_> {
for item in &array.items {
item_type_ids.push(self.typing_of_expression(item).as_type_id()?);
}
let element_type = self.types.common_mobile_type(&item_type_ids)?;
let element_type = self.types.type_of_array_literal(&item_type_ids)?;
Some(self.types.register_type(Type::FixedSizeArray {
element_type,
size: array.items.len(),
Expand Down
6 changes: 3 additions & 3 deletions crates/solidity-v2/outputs/cargo/semantic/src/passes/p4_resolve_references/visitor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ impl Visitor for Pass<'_> {
// TODO(validation) SDR[47]: both true_expression and false_expression should
// have the compatible types
let type_id = match (true_type_id, false_type_id) {
(Some(true_type_id), Some(false_type_id)) => self
.types
.common_mobile_type(&[true_type_id, false_type_id]),
(Some(true_type_id), Some(false_type_id)) => {
self.types.common_mobile_type(true_type_id, false_type_id)
}
_ => None,
};
self.binder.set_node_type(node.id(), type_id);
Expand Down
Loading
Loading