Skip to content

[v2] Simplify AST Type implementation to add LiteralType::mobile_type() #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggiraldez merged 9 commits into from
Jun 5, 2026
Merged

[v2] Simplify AST Type implementation to add LiteralType::mobile_type() #1793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8a322f2
Use named structs for semantic's `Type` enum
ggiraldez May 22, 2026
26ea238
Remove `ast::Type::type_id()` and make `create` non-public
ggiraldez May 22, 2026
24758ae
Store the variant struct into each variant of `ast::Type`
ggiraldez May 22, 2026
1d5d212
Expose `mobile_type()` for the AST `LiteralType`
ggiraldez May 22, 2026
47d02d6
Rename `precision_bits` to `decimal_places` in `FixedPointNumberType`
ggiraldez May 25, 2026
369039c
Implement `mobile_type()` for rationals returning fixed-point types
ggiraldez May 25, 2026
9d477fa
Fast-path for mobile type of rationals with non-periodic fractional part
ggiraldez May 25, 2026
73f9710
Change `LiteralKind::HexInteger`'s value to `BigUint` to enforce non-…
ggiraldez May 25, 2026
72262bf
Change iterative division by 2 for shift by trailing zeros
ggiraldez Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/solidity-v2/outputs/cargo/ast/generated/public_api.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions crates/solidity-v2/outputs/cargo/ast/src/abi/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ use sha3::{Digest, Keccak256};
use slang_solidity_v2_common::nodes::NodeId;
use slang_solidity_v2_semantic::binder::Definition;
use slang_solidity_v2_semantic::context::SemanticContext;
use slang_solidity_v2_semantic::types::{FunctionTypeMutability, Type, TypeId};
use slang_solidity_v2_semantic::types::{
ArrayType, FunctionTypeMutability, StructType, Type, TypeId,
};

pub struct ContractAbi {
node_id: NodeId,
Expand Down Expand Up @@ -392,12 +394,12 @@ fn type_as_abi_parameter_impl(
visited_structs: &mut HashSet<NodeId>,
) -> Option<(String, Vec<ParameterComponent>)> {
match semantic.types().get_type_by_id(type_id) {
Type::Array { element_type, .. } => {
Type::Array(ArrayType { element_type, .. }) => {
let (element_type_name, element_components) =
type_as_abi_parameter_impl(semantic, *element_type, visited_structs)?;
Some((format!("{element_type_name}[]"), element_components))
}
Type::Struct { definition_id, .. } => {
Type::Struct(StructType { definition_id, .. }) => {
// Recursive structs are not valid Solidity, but guard against cycles
// to avoid unbounded recursion if malformed types reach this point.
// TODO(validation) SDR[1]: The recursion should be detected in the
Expand Down
Loading
Loading