Skip to content

simplify jinja templates codegen#1820

Merged
OmarTawfik merged 3 commits into
mainfrom
OmarTawfik/stacks/versions/1/combine-templates-codegen
Jun 5, 2026
Merged

simplify jinja templates codegen#1820
OmarTawfik merged 3 commits into
mainfrom
OmarTawfik/stacks/versions/1/combine-templates-codegen

Conversation

@OmarTawfik

Copy link
Copy Markdown
Contributor

I Needed the ability to reference templates from other crates in a later PR downstream, so I'm doing the refactoring in a separate PR (this one) to make it easy to review:

  • parallelize all rendering of all templates in the codebase in one pass, instead of per-crate.
  • allow importing any templates with relative path from REPO_ROOT

As a nice side effect, infra check codegen (that runs on every file save) is now down to ~2s from ~6s.

@changeset-bot

changeset-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4c82930

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as ready for review June 2, 2026 15:43
@OmarTawfik OmarTawfik requested review from a team as code owners June 2, 2026 15:43

@teofr teofr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@OmarTawfik OmarTawfik added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 227d4da Jun 5, 2026
16 checks passed
@OmarTawfik OmarTawfik deleted the OmarTawfik/stacks/versions/1/combine-templates-codegen branch June 5, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants