[v2] Error on unresolvable or invalid inheritance bases#1830
Merged
Conversation
|
vladimirradosavljevic
force-pushed
the
sdr23
branch
2 times, most recently
from
e105bc5 to
5adc46d
Compare
OmarTawfik
approved these changes
Jun 5, 2026
vladimirradosavljevic
force-pushed
the
sdr23
branch
2 times, most recently
from
6a2da44 to
7e22200
Compare
Add a diagnostic when encountering unresolvable or invalid inheritance bases. Adds two diagnostic groups: Resolution (IdentifierNotFound) for bases that don't resolve, and Type System (InvalidBase) for bases that resolve to a non-contract/interface (e.g. a library, struct, or free function). Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
vladimirradosavljevic
force-pushed
the
sdr23
branch
from
7e22200 to
15febda
Compare
Contributor
|
Bencher Report| Branch | sdr23 |
| Testbed | ci |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a diagnostic when encountering unresolvable or invalid inheritance bases.
Adds two diagnostic groups: Resolution (IdentifierNotFound) for bases that don't resolve, and Type System (InvalidBase) for bases that resolve to a non-contract/interface (e.g. a library, struct, or free function).