[v2] Error when contract linearisation is impossible#1831
Open
vladimirradosavljevic wants to merge 1 commit into
Open
[v2] Error when contract linearisation is impossible#1831vladimirradosavljevic wants to merge 1 commit into
vladimirradosavljevic wants to merge 1 commit into
Conversation
|
vladimirradosavljevic
force-pushed
the
sdr23
branch
3 times, most recently
from
7e22200 to
15febda
Compare
vladimirradosavljevic
force-pushed
the
sdr24
branch
from
30faa02 to
92ce0d4
Compare
Contributor
|
Bencher Report| Branch | sdr24 |
| Testbed | ci |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Add two diagnostics from the linearisation pass: 1) cyclic-inheritance for inheritance cycles. 2) linearisation-impossible for inconsistent C3 orderings. Add a binder test for the forward-reference case, where solc errors but slang intentionally accepts it. Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
vladimirradosavljevic
force-pushed
the
sdr24
branch
from
92ce0d4 to
a1a21de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two diagnostics from the linearisation pass:
Add a binder test for the forward-reference case, where solc errors but slang intentionally accepts it.