add missing syntax tests#1834
Conversation
Add missing syntax tests for a bunch of solc syntax errors that are already covered by our LALRPOP grammar, so we don't need a specific diagnostic for it: - ParserError 9182: - `var` at contract-member position - ParserError 6933: - unchecked primary expressions in for-loop initializer and iterator slots - missing primary expressions in storage layout specifiers - ParserError 2314: - file-level constant with a visibility modifier - user-defined value type with a missing identifier - error definition with a parameter data location - empty inline-assembly flag list - user-defined operator with a missing function name
|
|
Bencher Report| Branch | OmarTawfik/add-missing-syntax-tests |
| Testbed | ci |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
🚨 3 Alerts
🐰 View full continuous benchmarking report in Bencher
teofr
left a comment
teofr
left a comment
There was a problem hiding this comment.
Thank you! Just one question
| use super::*; | ||
|
|
||
| #[test] | ||
| fn empty_flags() -> Result<()> { |
There was a problem hiding this comment.
I wonder if these tests should live in the diagnostics directory, since:
- The only part we care about is the error (the cst itself has no value)
- That way we can compare with
solc
2 participants
Add missing syntax tests for a few solc syntax errors that are already covered by our LALRPOP grammar, so we don't need a specific diagnostic for it:
varat contract-member position