Skip to content

add "PR Reviews" section to AGENTS.md#1844

Open
OmarTawfik wants to merge 1 commit into
mainfrom
OmarTawfik/add-pr-reviews-to-agents-md
Open

add "PR Reviews" section to AGENTS.md#1844
OmarTawfik wants to merge 1 commit into
mainfrom
OmarTawfik/add-pr-reviews-to-agents-md

Conversation

@OmarTawfik

Copy link
Copy Markdown
Contributor

With guidelines for addressing review feedback on pull requests, matching our existing guidelines.

With guidelines for addressing review feedback on pull requests, matching our existing guidelines.
@OmarTawfik OmarTawfik requested review from a team as code owners June 9, 2026 03:06
@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8106f0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik enabled auto-merge June 9, 2026 03:07
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

BranchOmarTawfik/add-pr-reviews-to-agents-md
Testbedci

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

🐰 View full continuous benchmarking report in Bencher

Comment thread AGENTS.md

## PR Reviews

When addressing review feedback on a pull request:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this may be better suited for a skill, or do you have a particular workflow in mind?

Comment thread AGENTS.md

When addressing review feedback on a pull request:

- **Work on top of the latest remote.** Before addressing feedback, fetch and check the remote branch in case the user pushed to it; always build on the most recent changes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deliberately don't give my agents access to ssh or other tokens beyond a tightly scoped gh token, which means they cannot pull remotes. So this would break my workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants