remove ExtraTerminal diagnostic

crates/solidity-v2/outputs/cargo/common/src/diagnostics/kinds/syntax/mod.rs

@@ -1,5 +1,4 @@
 mod expected_array_length_expression;
-mod extra_terminal;
 mod multiple_mutability_specifiers;
 mod multiple_override_specifiers;
 mod multiple_virtual_specifiers;
@@ -8,7 +7,6 @@ mod unexpected_terminal;
 mod unsupported_syntax;
 
 pub use expected_array_length_expression::ExpectedArrayLengthExpression;
-pub use extra_terminal::ExtraTerminal;
 pub use multiple_mutability_specifiers::MultipleMutabilitySpecifiers;
 pub use multiple_override_specifiers::MultipleOverrideSpecifiers;
 pub use multiple_virtual_specifiers::MultipleVirtualSpecifiers;
@@ -30,8 +28,6 @@ define_diagnostic_kind! {
         UnexpectedEof(UnexpectedEof),
         /// The parser encountered a terminal not valid at the current position.
         UnexpectedTerminal(UnexpectedTerminal),
-        /// The parser encountered extra input after a complete source unit.
-        ExtraTerminal(ExtraTerminal),
 
         /// A piece of syntax is not supported by the currently selected version.
         UnsupportedSyntax(UnsupportedSyntax),

crates/solidity-v2/outputs/cargo/parser/src/parser/mod.rs

@@ -1,9 +1,7 @@
 use std::collections::BTreeSet;
 
 use lalrpop_util::lalrpop_mod;
-use slang_solidity_v2_common::diagnostics::kinds::syntax::{
-    ExtraTerminal, UnexpectedEof, UnexpectedTerminal,
-};
+use slang_solidity_v2_common::diagnostics::kinds::syntax::{UnexpectedEof, UnexpectedTerminal};
 use slang_solidity_v2_common::diagnostics::DiagnosticCollection;
 use slang_solidity_v2_common::terminals::TerminalKind;
 use slang_solidity_v2_common::versions::LanguageVersion;
@@ -143,19 +141,9 @@ fn convert_parse_error(
                 },
             );
         }
-        lalrpop_util::ParseError::ExtraToken {
-            token: (left, lexeme, right),
-        } => {
-            diagnostics.push(
-                file_id.to_owned(),
-                left..right,
-                ExtraTerminal {
-                    found: TerminalKind::from(&lexeme),
-                },
-            );
-        }
-        lalrpop_util::ParseError::User { .. } => panic!("The parser should never return a user error, since we're not using any custom error types in our grammar"),
-        lalrpop_util::ParseError::InvalidToken { .. } => panic!("The parser should never return an invalid token error, since it's not using the default lexer"),
+        lalrpop_util::ParseError::ExtraToken { .. } => unreachable!("The parser should never return an extra token error: the top-level `SourceUnit` rule is a greedy repetition"),
+        lalrpop_util::ParseError::User { .. } => unreachable!("The parser should never return a user error, since we're not using any custom error types in our grammar"),
+        lalrpop_util::ParseError::InvalidToken { .. } => unreachable!("The parser should never return an invalid token error, since it's not using the default lexer"),
     }
 }
 

crates/solidity-v2/testing/snapshots/diagnostics_output/syntax/unexpected_terminal/trailing_token/input.sol

@@ -0,0 +1,5 @@
+// SPDX-License-Identifier: MIT
+pragma solidity *;
+
+contract Foo {}
+}