[mlir][Sol] Unify ABI tuple and packed encoders#126
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the MLIR codegen test suite to cover indexed event parameters that are struct types (both fully-static structs and structs containing dynamic members), and updates the semtest failure allowlist accordingly.
Changes:
- Removes
semanticTests/events/event_signature_in_libraryfromtest/mlirSemtestFailures.txt, indicating it is no longer expected to fail. - Adds a new
print-initlit test validatingsol.emitIR for indexed struct event arguments. - Adds a new EVM
print-std-mlirlit test validating lowering/codegen for hashing/log topics for indexed struct event arguments.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/mlirSemtestFailures.txt | Updates the semtest failure allowlist to stop treating event_signature_in_library as an expected failure. |
| test/lit/mlirCodegen/event_struct_indexed.sol | Adds print-init coverage for sol.emit with indexed struct arguments (static + dynamic). |
| test/lit/mlirCodegen/EVM/event_struct_indexed.sol | Adds EVM print-std-mlir coverage for indexed struct topic hashing/log emission. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abinavpp
force-pushed
the
app-event-arg-types
branch
from
1c950ef to
0a72492
Compare
abinavpp
force-pushed
the
app-event-struct-indexed
branch
from
51e634c to
9a86bcb
Compare
vladimirradosavljevic
requested changes
May 15, 2026
vladimirradosavljevic
left a comment
vladimirradosavljevic
left a comment
Contributor
There was a problem hiding this comment.
Please add semantic tests.
abinavpp
force-pushed
the
app-event-struct-indexed
branch
from
9a86bcb to
f3c3b93
Compare
abinavpp
changed the title
abinavpp
force-pushed
the
app-event-struct-indexed
branch
from
f3c3b93 to
7117cc5
Compare
vladimirradosavljevic
approved these changes
May 21, 2026
vladimirradosavljevic
left a comment
vladimirradosavljevic
left a comment
Contributor
There was a problem hiding this comment.
LGTM with test added for this.
Thank you and awesome work!
The literal RHS in bytes.push("c") and bytes.push() = "c" was not cast
to bytes1. Cast it.
abinavpp
force-pushed
the
app-event-arg-types
branch
from
0a72492 to
8674095
Compare
abinavpp
force-pushed
the
app-event-struct-indexed
branch
from
7117cc5 to
2bec6d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matter-labs/solx-llvm#67