[mlir][Sol] Cover modifier-on-constructor in lit tests#130
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Test-only PR that extends lit-test coverage to exercise modifiers applied to constructors, and removes two corresponding entries from the MLIR semantic-test failures list now that they pass.
Changes:
- Adds a
constructor() m(0) {}totest/lit/mlirCodegen/modifier.soland regenerates the FileCheck assertions. - Adds the same constructor to
test/lit/mlirCodegen/EVM/modifier.soland regenerates the EVM lowering assertions. - Removes
modifier_in_constructor_iceandmodifiers_in_construction_contextfromtest/mlirSemtestFailures.txt.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/mlirSemtestFailures.txt | Drops two modifier-on-constructor tests from the failure list. |
| test/lit/mlirCodegen/modifier.sol | Adds constructor with modifier and refreshes CHECK lines. |
| test/lit/mlirCodegen/EVM/modifier.sol | Adds constructor with modifier and refreshes CHECK lines for EVM lowering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vladimirradosavljevic
approved these changes
May 15, 2026
vladimirradosavljevic
left a comment
vladimirradosavljevic
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
abinavpp
force-pushed
the
app-blockhash-blobhash-selfdestruct
branch
from
595e744 to
331ef51
Compare
abinavpp
force-pushed
the
app-modifier-on-constructor-kind
branch
2 times, most recently
from
480103b to
e16453d
Compare
abinavpp
force-pushed
the
app-blockhash-blobhash-selfdestruct
branch
2 times, most recently
from
7e57ea7 to
08101cf
Compare
abinavpp
force-pushed
the
app-modifier-on-constructor-kind
branch
from
e16453d to
fc2ff64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matter-labs/solx-llvm#74