[mlir] Add tests for the struct deep-copy support

[PavelKopyl]

Also add cycle detection for recursive struct types in getType.

llvm

[Copilot]

Pull request overview

Adds MLIR codegen and semantic tests to validate deep-copy behavior for structs across storage/memory/calldata, and introduces cycle detection when materializing MLIR struct types to prevent infinite recursion.

Changes:

• Added new lit + semantic tests covering struct copies (sto→sto, sto→mem, mem→sto, cd→mem, cd→sto) with assertions for packing/sign-extension/bytesN alignment.
• Updated existing MLIR EVM lit checks for array copy codegen to reflect new generated IR (incl. additional cleanup/revert paths).
• Added recursive-struct cycle detection in SolidityToMLIRPass::getType and removed several entries from the MLIR semantic-test failure allowlist.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/mlirSemtestFailures.txt	Removes many previously-known failing upstream semantic tests related to struct/array copying.
test/lit/mlirCodegen/struct-copy.sol	New lit test asserting sol.copy/location-cast behavior for large nested structs.
test/lit/mlirCodegen/EVM/array-copy-widen.sol	Updates FileCheck expectations for widened packed array copy codegen.
test/lit/mlirCodegen/EVM/array-copy-packed.sol	Updates FileCheck expectations for packed array copy codegen (incl. masking/revert paths).
test/lit/mlirCodegen/EVM/array-copy-packed-widen.sol	Updates FileCheck expectations for packed+widen array copy codegen.
test/libsolidity/semanticTests/mlir/struct_copy_sto_to_sto.sol	New semantic test validating storage→storage struct copy preserves packed slot layout.
test/libsolidity/semanticTests/mlir/struct_copy_sto_to_mem.sol	New semantic test validating storage→memory copy applies read-side cleanup in memory.
test/libsolidity/semanticTests/mlir/struct_copy_mem_to_storage.sol	New semantic test validating memory→storage copy preserves packed slot bit layout.
test/libsolidity/semanticTests/mlir/struct_copy_cd_to_storage.sol	New semantic test validating calldata→storage struct copy and packing.
test/libsolidity/semanticTests/mlir/struct_copy_cd_to_mem.sol	New semantic test validating calldata→memory copy cleanup/alignment via raw mload checks.
libsolidity/codegen/mlir/SolidityToMLIR.cpp	Adds in-progress struct tracking to detect recursive struct type conversion cycles.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

[abinavpp]

amazing! thank you!

let's discuss recursive structs next week.