[mlir] Complete try/catch: fallback bytes clause and new-expression#135
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR completes MLIR frontend support for more try/catch forms in Solidity codegen, especially external calls with varying return arity, fallback bytes bindings, and try new Contract(...).
Changes:
- Extracts external-call lowering into reusable helpers that expose both status and result values.
- Adds
tryCallpropagation and success-status derivation for contract creation. - Adds fallback-clause parameter binding and updates lit/semantic failure expectations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
libsolidity/codegen/mlir/SolidityToMLIR.cpp |
Refactors external-call lowering and extends try/catch handling for creation and fallback data. |
test/lit/mlirCodegen/try.sol |
Adds init-MLIR coverage for try new Other(). |
test/lit/mlirCodegen/EVM/try.sol |
Adds EVM-lowered MLIR coverage for try new Other(). |
test/mlirSemtestFailures.txt |
Removes semantic tests now expected to pass. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abinavpp
force-pushed
the
app-trycatch-fallback-clause
branch
from
5f6c0a1 to
a6c6807
Compare
abinavpp
force-pushed
the
app-trycatch-fallback-clause
branch
from
a6c6807 to
34818bb
Compare
abinavpp
force-pushed
the
app-trycatch-fallback-clause
branch
from
34818bb to
5549c50
Compare
abinavpp
force-pushed
the
app-trycatch-fallback-clause
branch
from
5549c50 to
b1485ab
Compare
abinavpp
force-pushed
the
app-trycatch-fallback-clause
branch
from
b1485ab to
cbccdc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matter-labs/solx-llvm#79