[mlir] Add lit test for data-in-code globals#138
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new literals-2 MLIR codegen lit test case to validate handling of long concatenated string/bytes literals in an internal library function used by a contract constructor (covering the __data_in_code__* path across object boundaries), and updates the semantic test failure allowlist to reflect recently-fixed deployed-code-exclusion cases.
Changes:
- Remove several
semanticTests/deployedCodeExclusion/*entries from the known-failures list. - Add
test/lit/mlirCodegen/literals-2.solto checkprint-initMLIR for the new literal scenario. - Add
test/lit/mlirCodegen/EVM/literals-2.solto check EVM-targetprint-std-mliroutput for the same scenario.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/mlirSemtestFailures.txt | Drops no-longer-failing deployedCodeExclusion semantic tests from the failure list. |
| test/lit/mlirCodegen/literals-2.sol | New print-init lit test covering long literal returned from internal library function and copied into contract storage in ctor. |
| test/lit/mlirCodegen/EVM/literals-2.sol | New EVM print-std-mlir lit test asserting __data_in_code__* emission for the same scenario across object modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abinavpp
force-pushed
the
app-clone-data-in-code-globals
branch
from
fd4d326 to
6273bdd
Compare
abinavpp
changed the title
abinavpp
force-pushed
the
app-clone-data-in-code-globals
branch
from
6273bdd to
c915dc1
Compare
abinavpp
changed the title
abinavpp
force-pushed
the
app-trycatch-fallback-clause
branch
2 times, most recently
from
b1485ab to
cbccdc7
Compare
abinavpp
force-pushed
the
app-clone-data-in-code-globals
branch
from
c915dc1 to
2d90e8f
Compare
abinavpp
force-pushed
the
app-clone-data-in-code-globals
branch
from
2d90e8f to
0462935
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matter-labs/solx-llvm#82