[mlir] Add tests for the bytesN bitwise/shift ops fix

[PavelKopyl]

matter-labs/solx-llvm#86

[Copilot]

Pull request overview

This PR updates MLIR codegen and lit coverage to validate the corrected handling of bytesN bitwise (& | ^ ~) and shift (<< >>) operations, and removes a couple of semantic tests from the “expected failures” list now that they pass.

Changes:

• Update SolidityToMLIRPass to emit sol.{and,or,xor,shl,shr,not} directly on !sol.fixedbytes<N> operands (and allow shift RHS to stay in its “mobile” integer type).
• Refresh existing FileCheck expectations for bytes/fixedbytes bitwise and shift lowering (both Sol and EVM pipelines).
• Add new fixedbytes.sol lit tests (Sol + EVM) covering comparisons, bitwise ops, unary ~, shifts, and mixed-size fixed-bytes operands; remove now-passing semtests from the MLIR failure list.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/mlirSemtestFailures.txt	Removes two tests from the expected-MLIR-failures list because they now pass.
test/lit/mlirCodegen/shift-bytes.sol	Updates checks to expect direct sol.shl/sol.shr on !sol.fixedbytes<20> rather than cast-to-int shims.
test/lit/mlirCodegen/fixedbytes.sol	New lit test covering bytesN comparisons/bitwise/shift/unary-not (Sol pipeline).
test/lit/mlirCodegen/EVM/shift-bytes.sol	Updates EVM-lowering checks for fixed-bytes shifts to match new lowering pattern.
test/lit/mlirCodegen/EVM/fixedbytes.sol	New lit test covering bytesN comparisons/bitwise/shift/unary-not (EVM pipeline).
test/lit/mlirCodegen/EVM/arith.sol	Updates expected lowering for bytes4 bitwise-not and some shift-related masking behavior.
test/lit/mlirCodegen/bytes.sol	Updates checks to expect sol.and/or/xor directly on !sol.fixedbytes<5> rather than int casts.
test/lit/mlirCodegen/arith.sol	Updates checks to reflect direct sol.not on !sol.fixedbytes<4> and updated shift op typing.
libsolidity/codegen/mlir/SolidityToMLIR.cpp	Core codegen change: stop converting bytesN to ints for bitwise/shift ops; emit ops directly with appropriate result/RHS typing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[abinavpp]

thank you!

[vladimirradosavljevic]

LGTM. Can we add tests for ByteType?

[PavelKopyl]

LGTM. Can we add tests for ByteType?

Yes, but it doesn’t seem easy to generate such a test from Solidity. I’ve created a test directly from the Sol dialect: matter-labs/solx-llvm#87