This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Add {save,restore}_checkpoint to PartialPaths to rewind the arena allocator pointers
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggiraldez
force-pushed
the
partial-paths-checkpoint
branch
from
987b964 to
ff0bf65
Compare
OmarTawfik
force-pushed
the
partial-paths-checkpoint
branch
from
ff0bf65 to
fd5323e
Compare
OmarTawfik
reviewed
Dec 24, 2024
OmarTawfik
reviewed
Dec 24, 2024
OmarTawfik
approved these changes
Dec 24, 2024
OmarTawfik
left a comment
OmarTawfik
left a comment
There was a problem hiding this comment.
LGTM!
Added a couple of suggestions, to help identify the additions in any future merge from upstream.
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this pull request
Oct 16, 2025
…ewind the arena allocator pointers Copied over from our fork: NomicFoundation/stack-graphs#2
OmarTawfik
added a commit
to NomicFoundation/slang
that referenced
this pull request
Oct 16, 2025
…ewind the arena allocator pointers Copied over from our fork: NomicFoundation/stack-graphs#2
github-merge-queue bot
pushed a commit
to NomicFoundation/slang
that referenced
this pull request
Oct 16, 2025
…ewind the arena allocator pointers (#1446) Copied over from our fork: NomicFoundation/stack-graphs#2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use
PartialPathsfor a database of pre-computed minimal partial paths for resolution and reuse it to resolve many references without increasing the memory used.