Conversation
gaeulzzang
approved these changes
Mar 25, 2025
Contributor
gaeulzzang
left a comment
gaeulzzang
left a comment
There was a problem hiding this comment.
올바르지 않은 그룹코드를 입력했을 때, 네트워크 안켰을 때 각각 failure 처리 잘해놨네욤 귯걸
youjin09222
approved these changes
Mar 27, 2025
Contributor
youjin09222
left a comment
youjin09222
left a comment
There was a problem hiding this comment.
넘넘 깔끔하네요~! 고생 많았습니다ㅏㅏㅏ
presentation/src/main/java/com/sopt/presentation/groupEnter/GroupEnterRoute.kt
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/groupEnter/GroupEnterViewModel.kt
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/groupEnter/GroupEnterViewModel.kt
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/groupEnter/GroupEnterViewModel.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
2025-03-25.3.16.07.mov
2025-03-25.2.46.29.mov
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
그룹 코드 띄워놓은게 넘 작아서 타이핑 한참 걸림;