Merged
Conversation
Eonji-sw
approved these changes
Mar 27, 2025
Member
Eonji-sw
left a comment
Eonji-sw
left a comment
There was a problem hiding this comment.
ㅋㅋ 로직 넘 어려워영
영상 올리면 더 좋을 것 같네요 ^^
| ) { | ||
| members.forEachIndexed { index, member -> | ||
| val isMeAvailable = index == 0 && myIdentity.availability == "available" && myIdentity.name == member | ||
| val isMeAvailable = index == 0 && myIdentity.availability == "AVAILABLE" && myIdentity.name == member |
| ) { | ||
| members.forEachIndexed { index, member -> | ||
| val isMeUnavailable = index == 0 && myIdentity.availability == "unavailable" && myIdentity.name == member | ||
| val isMeUnavailable = index == 0 && myIdentity.availability == "UNAVAILABLE" && myIdentity.name == member |
Comment on lines
+139
to
+140
| Timber.d("getOptionsState: $getOptionsState") | ||
| Timber.d("getTimeTableState: $getTimeTableState") |
Contributor
Author
There was a problem hiding this comment.
싹 다 날려버려 싹 다 날려 전부 싹 다 날려버려 싹 다 Ah-Woo 싹 다 지워버려 싹 다 지워 전부 싹 다 지워버려 싹 다 You know I'm a
youjin09222
approved these changes
Mar 27, 2025
Comment on lines
+36
to
+57
| onFailure = { throwable -> | ||
| when (throwable) { | ||
| is IOException -> { | ||
| _postTimeTableState.emit(UiState.Failure(throwable.message.toString())) | ||
| emitSideEffect( | ||
| AppointmentCheckSideEffect.ShowErrorDialog( | ||
| true, | ||
| DialogType.NETWORK_FAILURE | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| else -> { | ||
| _postTimeTableState.emit(UiState.Failure(throwable.message.toString())) | ||
| emitSideEffect( | ||
| AppointmentCheckSideEffect.ShowErrorDialog( | ||
| true, | ||
| DialogType.DATA_FAILURE | ||
| ) | ||
| ) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
P3: 꼼꼼한 에러 처리 넘 좋습니다ㅏㅏ
Comment on lines
+13
to
+16
| fun toggleLike(itemId: Long, defaultLiked: Boolean, defaultLikes: Int) { | ||
| val (isLiked, likes) = _likeStates[itemId] ?: (defaultLiked to defaultLikes) | ||
| _likeStates[itemId] = !isLiked to if (isLiked) likes - 1 else likes + 1 | ||
| } |
Contributor
There was a problem hiding this comment.
P3: viewModel에서 좋아요 처리하게 바꾸셨네요! 아주 좋습니다👍👍
…into feature/#66-appoinment-api-feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
첫번째 영상에서는 타임테이블에 시간 입력하는 기능 중심으로 봐주시면 됩니다.
두번째 영상에서는 좋아요 기능, 약속 확정 기능 확인해주시면 됩니다.
현재, 옵션 상세 뷰에서 가능한 친구, 불가능한 친구 정보가 빈 리스트로 오고 있어서 해당 이슈는 서버 요청 사항에 적어두었습니다.
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
금방 연결할 줄 알고 맡은 api 싹다 같은 브랜치에서 작업했는데 계속 수정되고 잘 안돌아가서 pr 먼저 올립니다. 제가 참 오만하고 방자했네요 ^^
약속 내용 확정하는 것 빼고는 나머지 api 잘 돌아가는거 확인했습니다.
노션 명세서대로 다 해놓은 상태인데 언젠간 다 연결되겠죠??? pr 닫히려면 몇주 걸릴까요~~????
비실이 탈출하고 비브라늄 멘탈 장착하고 오겠습니다.
땡스 투 갈길게여 💋💘💚 @youjin09222 @twogarlic @Eonji-sw