[Feature/#86] : UI 변경 및 약속 생성 백스택 정리#87
Merged
gaeulzzang merged 6 commits intodevelopfrom Apr 8, 2025
Merged
Conversation
twogarlic
reviewed
Apr 8, 2025
| .border( | ||
| width = 1.dp, | ||
| color = if (isSelected) NoostakTheme.colors.gray500 else NoostakTheme.colors.blue100, | ||
| color = if (isSelected) NoostakTheme.colors.blue700 else NoostakTheme.colors.gray100, |
Contributor
Author
There was a problem hiding this comment.
무야호오오옹 드디어 색깔 바뀐다 ㅋ
twogarlic
approved these changes
Apr 8, 2025
Contributor
twogarlic
left a comment
twogarlic
left a comment
There was a problem hiding this comment.
맘이랑 몸 모두 고생많으셧슴니다 ,,... 이거 날리고 차단 당하셧던것 맞죠?
Contributor
Author
넴.... 덕분에 velog에 글 썼어여 >< |
youjin09222
approved these changes
Apr 8, 2025
Contributor
youjin09222
left a comment
youjin09222
left a comment
There was a problem hiding this comment.
진짜 고생 많았어ㅓㅓㅓ 억까 제발 멈춰...
| ), | ||
| .align(Alignment.BottomCenter) | ||
| .padding(bottom = dimensionResource(id = R.dimen.vertical_padding)) | ||
| .zIndex(1f), |
Contributor
There was a problem hiding this comment.
P3: zIndex로 버튼 가림 현상까지 방지하셨네요~! 👍👍👍
Comment on lines
-140
to
+141
| top.linkTo(parent.top) | ||
| start.linkTo(parent.start) | ||
| }, | ||
| text = stringResource(R.string.title_appointment_check), | ||
| color = NoostakTheme.colors.black, | ||
| style = NoostakTheme.typography.h4Bold, | ||
| textAlign = TextAlign.Start | ||
| ) | ||
| NoostakEditableTimeTable( | ||
| availablePeriods = availablePeriods, | ||
| modifier = Modifier | ||
| .constrainAs(timeTable) { | ||
| top.linkTo(title.bottom) | ||
| start.linkTo(parent.start) | ||
| end.linkTo(parent.end) | ||
| height = Dimension.fillToConstraints | ||
| } | ||
| .fillMaxSize() | ||
| .padding(bottom = 80.dp) |
Contributor
There was a problem hiding this comment.
P3: 버튼 영역과 겹치지 않도록 공간 확보하신건가요? 너무 좋습니다!
Comment on lines
+46
to
+48
| BackHandler { | ||
| appointmentSubmitCompleteViewModel.navigateToGroupDetail(groupId) | ||
| } |
Contributor
There was a problem hiding this comment.
P3: 오 이렇게 BackHandler를 활용해서 ViewModel에서 명시적으로 네비게이션을 처리할 수 있군요? 새롭게 배워갑니다ㅏㅏㅏ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
default.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
현재 화면 전환 시 백스택을 정리하기 위해 NavOptions의 setPopUpTo() 함수를 사용하고 있습니다.
그러나 건너뛰려는 화면이 백스택에 존재하지 않을 경우, 해당 로직이 실행되지 않아 백스택 정리가 되지 않는 문제가 발생했습니다.
예를 들어,
그룹 상세 뷰에서 약속 생성을 할 경우: CalendarSubmitComplete → GroupDetail (setPopUpTo(GroupDetail) 실행)
하지만 캘린더 홈에서 바로 약속 생성을 할 경우 GroupDetail 화면이 백스택에 존재하지 않기 때문에 setPopUpTo(GroupDetail)이 무의미하게 됩니다.
이러한 NavOptions의 한계를 고려하여, 해당 상황에서는 BackHandler를 활용해 직접 백스택을 제어하도록 처리하였습니다.
더 좋은 방법이 있다면 알려주세요ㅠㅠ 😢