-
Notifications
You must be signed in to change notification settings - Fork 14
FCO2 fire fix #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCO2 fire fix #157
Conversation
| for the CLM2 data in the CESM distribution --> | ||
| <!-- Plant function types (relative to {csmdata}) --> | ||
| <paramfile phys="clm6_0" >lnd/clm2/paramdata/ctsm60_params.c250311.nc</paramfile> | ||
| <paramfile phys="clm6_0" >lnd/clm2/paramdata/ctsm60_params.250923_v26j.nc</paramfile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this one 26j and the other 26i?
This reverts commit 9bc0a95.
|
The changes to the CTSM parameter file needed for this are: < d_max = 10 ;
and the path to the parameter file I am using is: /cluster/work/users/rosief/NorESM_3_0_beta01_ctsm_v9/cime/scripts/ctsm60_params.v28m.nc |
Description of changes
This removes the zeroing of the fire and grazing fluxes in the clmfate interface, replacing them with zeroing in the FATES patch routines in NorESMhub/fates#32 , and thus fixes the bias in the fire output fluxes.
Specific notes
Contributors other than yourself, if any:
@kjetilaas @maritsandstad
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)?
Yes, to FCO2. Which will have larger fluxes replating to fire.
Any User Interface Changes (namelist or namelist defaults changes)?
No
Does this create a need to change or add documentation? Did you do so?
No
Testing performed, if any:
Here are the comparisons for (second and third rows) the default FCO2 when ONLY FIRE is used to generate it, vs the reported history fire flux, and the error between those two. The default has large (~10^-7) errors compared to the fixed version (~10^-10). The top row here is the same comparison when only the CLM HR is used to define FCO2, showing that there is some residual error. The remaining error is currently unxplained...
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).